Hi Akshay, I am sorry I do not have access to my machine right now. I will try to work on it (and the JS patch) once I get the chance to.
On Mon, Aug 19, 2019, 9:49 AM Akshay Joshi <akshay.jo...@enterprisedb.com> wrote: > Hi Yosry > > Test cases are failing on our build machines. When I reviewed your patch I > have run test cases with paramaster "*--pkg tools.sqleditor.tests*" on > multiple database servers and every time test case has been passed. > > But on build machines we run test cases with parameter "*--pkg all* *--exclude > feature_tests" *on multiple database server and it fails for second > server onwards. I have also tried the same and it is failing on my machine > too. > > I am debugging the code why it is getting failed, but if you found any > solution please send the patch asap. > > On Mon, Aug 19, 2019 at 11:48 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Thanks patch applied. >> >> On Sat, Aug 17, 2019 at 6:22 PM Yosry Muhammad <yosry...@gmail.com> >> wrote: >> >>> Hi Hackers, >>> >>> Please find attached a patch including new python test that checks the >>> transaction status after executing queries and saving data when auto-commit >>> is on/off. It also includes some refactoring of previously written python >>> tests. >>> >>> Please review ! >>> Thanks. Regards. >>> >>> -- >>> *Yosry Muhammad Yosry* >>> >>> Computer Engineering student, >>> The Faculty of Engineering, >>> Cairo University (2021). >>> Class representative of CMP 2021. >>> https://www.linkedin.com/in/yosrym93/ >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* >
