Hi Akshay, Please find the updated patch. I have accommodated all the changes mentioned in the review.
On Thu, Jan 16, 2020 at 5:54 PM Akshay Joshi <akshay.jo...@enterprisedb.com> wrote: > Hi Pradip > > Below are the review comments: > > - Format the JSON file. Rename the JSON file from > 'language_testcases.json' to 'language_test_data.json'. > - For consistency please follow the naming convention used in ' > *cast_test_data.json*' file. For example, in Cast we have used 'name' > and in Languages, we used 'Test_case'. > - Move all the data in the JSON file from python file. > - Move mocking function name and return value to the JSON file, as we > did in '*cast_test_data.json*' file. > - Move "*generate_scenarios*" function to > "web/regression/python_test_utils/test_utils.py" > > Can you please fix the following for CAST node: > > - Remove 'TC-..' from all the scenario name. > - Used the same generic function(generate_scenario) from test_utils. > > > > On Wed, Jan 15, 2020 at 2:19 PM Pradip Parkale < > pradip.park...@enterprisedb.com> wrote: > >> Hi All, >> >> Attached is a patch for language node code coverage. >> This increases the code coverage of the language node from 45% to 69%. >> >> Command to run the tests - >> - python runtests.py --pkg >> browser.server_groups.servers.databases.languages.tests >> >> >> -- >> Thanks & Regards, >> Pradip Parkale >> QMG, EnterpriseDB Corporation >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > -- Thanks & Regards, Pradip Parkale QMG, EnterpriseDB Corporation
RM5050_v2.patch
Description: Binary data
