Thanks, patch applied. On Fri, Mar 6, 2020 at 12:21 PM Nagesh Dhope <nagesh.dh...@enterprisedb.com> wrote:
> Hi Akshay, > Please find a patch to make controls under *Active query details* subnode > read-only on the dashboard. > > > On Fri, Jan 31, 2020 at 12:38 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Thanks, patch applied. >> >> On Thu, Jan 30, 2020 at 1:55 PM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached is the updated patch to include dialogs (create/edit) for all >>> the nodes. >>> Kindly review. >>> >>> On Thu, Jan 23, 2020 at 1:08 PM Akshay Joshi < >>> akshay.jo...@enterprisedb.com> wrote: >>> >>>> Hi Aditya >>>> >>>> As per discussion, we should visit all the nodes create/edit dialog and >>>> make the controls read-only wherever appropriate. >>>> >>>> On Wed, Jan 22, 2020 at 5:46 PM Aditya Toshniwal < >>>> aditya.toshni...@enterprisedb.com> wrote: >>>> >>>>> Hi Hackers, >>>>> >>>>> Attached is the patch to allow input controls to be set as readonly >>>>> instead of disabled. >>>>> I've also changed the code for the nodes to make sure properties tab >>>>> have readonly fields wherever applicable. This will allow tab navigation >>>>> in >>>>> properties tab and also allow screen readers to read it. >>>>> Please note that, I've not visited each and every node create/edit >>>>> dialog to identify what should be readonly or what should be disabled as >>>>> it >>>>> depends on business logic. The patch is mainly for the properties tab. >>>>> >>>>> Kindly review. >>>>> >>>>> -- >>>>> Thanks and Regards, >>>>> Aditya Toshniwal >>>>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune >>>>> "Don't Complain about Heat, Plant a TREE" >>>>> >>>> >>>> >>>> -- >>>> *Thanks & Regards* >>>> *Akshay Joshi* >>>> >>>> *Sr. Software Architect* >>>> *EnterpriseDB Software India Private Limited* >>>> *Mobile: +91 976-788-8246* >>>> >>> >>> >>> -- >>> Thanks and Regards, >>> Aditya Toshniwal >>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune >>> "Don't Complain about Heat, Plant a TREE" >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > > > -- > Thanks, > Nagesh > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*