Thanks, patch applied. On Wed, Apr 1, 2020 at 6:05 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote:
> Hi Hackers, > > Attached is the updated patch. The issue was on PG9.6, fixed that. > Docs updated. > > Please review. > > On Wed, Apr 1, 2020 at 5:37 PM Akshay Joshi <akshay.jo...@enterprisedb.com> > wrote: > >> Documentation and Screenshot need to be updated. >> >> On Wed, Apr 1, 2020 at 5:10 PM Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi Aditya >>> >>> Tested on 9.6, test cases are fixed but wrong SQL generated for tables: >>> CREATE TABLE public.test >>> ( >>> col1 bigint >>> ) >>> WITH ( >>> OIDS = FALSE,, >>> parallel_workers = 56 autovacuum_enabled = TRUE, >>> >>> Also parameter parallel_workers is not showing until we enabled the >>> autovacuum parameters. >>> >>> Please fix and resend the patch. >>> >>> On Wed, Apr 1, 2020 at 3:35 PM Aditya Toshniwal < >>> aditya.toshni...@enterprisedb.com> wrote: >>> >>>> Hi Akshay, >>>> >>>> On Wed, Apr 1, 2020 at 2:51 PM Akshay Joshi < >>>> akshay.jo...@enterprisedb.com> wrote: >>>> >>>>> Hi Aditya >>>>> >>>>> API/RESQL test cases are failing for EPAS/PG 9.6 and maybe above. >>>>> Please fix and resend the patch. >>>>> >>>> The SQL is corrected for 9.6 versions. Others seems to be working fine. >>>> Attached is the updated patch. >>>> Please review. >>>> >>>>> >>>>> On Mon, Mar 30, 2020 at 7:47 PM Aditya Toshniwal < >>>>> aditya.toshni...@enterprisedb.com> wrote: >>>>> >>>>>> Hi Hackers, >>>>>> >>>>>> Attached is a patch to add support for parameters toast_tuple_target >>>>>> (PG v11+) and parallel_workers(PG 9.6+) of table. Refer - >>>>>> https://www.postgresql.org/docs/11/sql-createtable.html#SQL-CREATETABLE-STORAGE-PARAMETERS >>>>>> . >>>>>> >>>>>> Both the parameters are added in the advanced tab of table dialog. >>>>>> >>>>>> The patch also fixes a related issue - RM5180, >>>>>> where autovacuum_enabled parameter is added automatically in the RE-SQL >>>>>> when table has been created with WITH parameter. >>>>>> >>>>>> Please review. >>>>>> >>>>>> -- >>>>>> Thanks and Regards, >>>>>> Aditya Toshniwal >>>>>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune >>>>>> "Don't Complain about Heat, Plant a TREE" >>>>>> >>>>> >>>>> >>>>> -- >>>>> *Thanks & Regards* >>>>> *Akshay Joshi* >>>>> >>>>> *Sr. Software Architect* >>>>> *EnterpriseDB Software India Private Limited* >>>>> *Mobile: +91 976-788-8246* >>>>> >>>> >>>> >>>> -- >>>> Thanks and Regards, >>>> Aditya Toshniwal >>>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune >>>> "Don't Complain about Heat, Plant a TREE" >>>> >>> >>> >>> -- >>> *Thanks & Regards* >>> *Akshay Joshi* >>> >>> *Sr. Software Architect* >>> *EnterpriseDB Software India Private Limited* >>> *Mobile: +91 976-788-8246* >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > > > -- > Thanks and Regards, > Aditya Toshniwal > pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
