Re: [pgAdmin][RM5043] Column names not in creation order during - refresh via context menu required to resort them properly

[Satish V]

Hi,

Here is an updated patch which makes the columns(44 and more ) showing up
in the creation order rather than alphabetical sorting. Changes happen
inside the browser tree.

Thanks & Regards
Sathish V

On Thu, Apr 23, 2020 at 8:04 AM Akshay Joshi <akshay.jo...@enterprisedb.com>
wrote:

> Thanks, patch applied.
>
> On Thu, Apr 23, 2020 at 12:02 PM navnath gadakh <
> navnath.gad...@enterprisedb.com> wrote:
>
>> Hello,
>>
>>  Patch looks good to me. Newly created columns sorted according to their
>> creation order without context refresh.
>>
>> Thanks!
>>
>> On Thu, Apr 23, 2020 at 10:13 AM navnath gadakh <
>> navnath.gad...@enterprisedb.com> wrote:
>>
>>> Hi,
>>>
>>>  I'm reviewing this patch.
>>>
>>> On Wed, Apr 22, 2020 at 6:54 PM Satish V <satis...@enterprisedb.com>
>>> wrote:
>>>
>>>>
>>>> Hi Hackers,
>>>>
>>>> In the attached patch, newly created columns in a table are sorted
>>>> according to their creation order rather than the alphanumerical order.
>>>> Previously this was not happening without context refresh.
>>>>
>>>>
>>>>
>>>> Please review.
>>>>
>>>> Thanks
>>>> Sathish V
>>>>
>>>
>>>
>>> --
>>> Regards,
>>> Navnath Gadakh
>>>
>>
>>
>> --
>> Regards,
>> Navnath Gadakh
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>

diff --git a/web/pgadmin/browser/static/js/browser.js b/web/pgadmin/browser/static/js/browser.js
index 4ed30a2..20b2eb2 100644
--- a/web/pgadmin/browser/static/js/browser.js
+++ b/web/pgadmin/browser/static/js/browser.js
@@ -1037,8 +1037,8 @@ define('pgadmin.browser', [
                     i = items.eq(e);
                     d = ctx.t.itemData(i);
                     if (d._type === 'column') {
-                      if (pgAdmin.numeric_comparator(d._id, _data._id) != -1)
-                        return true;
+                      if (pgAdmin.numeric_comparator(d._id, _data._id) == -1)
+                        return false;
                     } else {
                       if (pgAdmin.natural_sort(d._label, _data._label) != 1)
                         return true;