Hi Dave

Patch looks good to me except one small change in the README file that is
PGADMIN_PYTHON_PATH is mentioned but it should be PGADMIN_PYTHON_DIR

On Fri, May 1, 2020 at 8:29 PM Dave Page <dp...@pgadmin.org> wrote:

> The attached patch tidies up the qmake code for configuring the runtime
> build so that it's consistent on all platforms, and simply requires that
> the PGADMIN_PYTHON_DIR environment variable points to the Python
> installation to be used.
>
> Please review, but don't commit, as this change will probably break some
> of the Jenkins jobs. I'll commit and fix them when the patch has passed
> review.
>
> (Sidenote: this is part of a larger tidy up/standardisation of the build
> scripts).
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

Reply via email to