Hi Dave
Patch looks good to me except the below line gets commented by mistake (if
i am not wrong)
# ./complete-bundle.sh "${BUILDROOT}/${APP_BUNDLE_NAME}" || { echo
complete-bundle.sh failed; exit 1; }
On Mon, May 4, 2020 at 3:02 PM Dave Page <dp...@pgadmin.org> wrote:
> Here's a rebased version.
>
> On Mon, May 4, 2020 at 7:33 AM Akshay Joshi <akshay.jo...@enterprisedb.com>
> wrote:
>
>> Hi Dave
>>
>> On Fri, May 1, 2020 at 5:21 PM Dave Page <dp...@pgadmin.org> wrote:
>>
>>> Akshay, are you happy with this patch?
>>>
>>
>> The patch is not applied to the latest code.
>>
>>>
>>> On Mon, Apr 27, 2020 at 3:30 PM Dave Page <dp...@pgadmin.org> wrote:
>>>
>>>>
>>>>
>>>> On Mon, Apr 27, 2020 at 3:28 PM Khushboo Vashi <
>>>> khushboo.va...@enterprisedb.com> wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> The code looks good to me. The package building was tested by Neel and
>>>>> we found that the venv was built with Python 3+ but the runtime was built
>>>>> against Python 2.7.
>>>>> As per Dave, Neel may have not used a venv of the correct version as
>>>>> it is working fine on Dav'e system. So, we can commit the patch.
>>>>>
>>>>
>>>> Yeah, that's not ideal, but the same problem exists today. I need to
>>>> spend some time figuring out how to make that more robust.
>>>>
>>>> --
>>>> Dave Page
>>>> Blog: http://pgsnake.blogspot.com
>>>> Twitter: @pgsnake
>>>>
>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>>
>> *Sr. Software Architect*
>> *EnterpriseDB Software India Private Limited*
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
--
*Thanks & Regards*
*Akshay Joshi*
*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*
