Hi Dave Patch looks good to me, did eyeball review.
On Fri, May 29, 2020 at 1:43 PM Dave Page <dp...@pgadmin.org> wrote: > Stupid line endings confusing git :-(. Here's another attempt. > > On Fri, May 29, 2020 at 7:30 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Dave >> >> Unable to apply the patch. Can you please rebase and send it again. >> >> On Thu, May 28, 2020 at 9:04 PM Dave Page <dp...@pgadmin.org> wrote: >> >>> Here's a patch to cleanup the windows build system and make sure 64 bit >>> builds work with modern tools. It also updates the README with a new >>> from-scratch setup process that makes it much easier to setup a Windows >>> build/dev machine. >>> >>> Please review, but don't apply as I'll need to do that in conjunction >>> with some Jenkins changes. >>> >>> Note that I haven't tested a 32 bit build as I don't have a working >>> environment for that to hand and don't really want to spend time setting >>> one up before we deprecate it. I'll fix any issues that show up in Jenkins. >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
