Thanks, patch applied. On Wed, Jul 1, 2020 at 11:04 AM Pradip Parkale < pradip.park...@enterprisedb.com> wrote:
> Hi Akshay, > > Please find the attached patch for following fixes, > > - RM5631 - [RLS Policy] can't execute an empty query. > - In case of more than one policy, all the headers are showing as a > comment on top of policy DDL in schema diff. - Fixed > - If the policy event is different for source and target policy then > it is showing different but no diff SQL has been generated. - Fixed > - All function arguments are in the right sequence. > - RLS policy warning in table dialog was popping up multiple times - > Fixed. > - 'With Check' rename to 'With check'. > - Added re-sql test case for using and with check. > - Modified check policy? message. > > > On Fri, Jun 26, 2020 at 6:07 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Pradip >> >> Following are the review comments: >> >> - For function arguments please make sure the right sequence is *gid, >> sid, did, scid, <object-id> ... *All the parameters are not >> compulsory but the parameters should be in the mentioned order for >> consistency. Change it to all the functions of RLS Policy wherever not >> followed, revisit the already committed code as well. >> - In case of more than one policy, all the headers are showing as a >> comment on top of policy DDL in schema diff. >> - If the policy event is different for source and target policy then >> it is showing different but no diff SQL has been generated. >> - Created new RM #5631, fixed that to test schema diff further. >> >> >> On Thu, Jun 25, 2020 at 7:38 PM Pradip Parkale < >> pradip.park...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Please find the attached patch for RLS policy support in schema diff. >>> >>> -- >>> Thanks & Regards, >>> Pradip Parkale >>> QMG, EnterpriseDB Corporation >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > > > -- > Thanks & Regards, > Pradip Parkale > QMG, EnterpriseDB Corporation > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
