Hi Akshay, Looks OK to me. Please commit and have Fahar do some more in-depth testing and if he finds anything else we can incrementally fix that before the next release.
Thanks! On Mon, Aug 24, 2020 at 3:05 PM Akshay Joshi <akshay.jo...@enterprisedb.com> wrote: > Hi Dave/Hackers > > Attached is the patch to fix the following issues: > > - Enable the 'Configure' and 'View log' menu option when the server > taking longer than usual time to start. > - When an error occurs from the backend, the configure window opens > and if the user has changed the setting of the port, it won't take any > effect as we have retrieved the value of the port at the start of the > runtime. > - Added logic to identify the specified fixed port is already in use. > Throw the error before starting the pgAdmin server. > > Please review and let me know any comments. > > -- > *Thanks & Regards* > *Akshay Joshi* > *pgAdmin Hacker | Sr. Software Architect* > *EDB Postgres <http://edbpostgres.com>* > > *Mobile: +91 976-788-8246* > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EDB: http://www.enterprisedb.com
