Thanks, patch applied. On Wed, Nov 4, 2020 at 12:43 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote:
> Hi Akshay, > > Please find the updated patch, resolved all review comments. > > Regards, > Nikhil Mohite. > > On Wed, Nov 4, 2020 at 11:24 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Nikhil >> >> Following are the review comments: >> >> - "Tabs settings" should be renamed to "Tab settings". >> - "Debugger Tab title" should be renamed to the "Debugger tab title". >> - "Enable dynamic tab size" should be renamed to "Dynamic tab size". >> - Add help message for the "Dynamic tab size" option mentioning that >> it will affect the existing opened tab. >> - The size of switch control <True/False> needs to be increased, as >> the text is not properly displayed. >> - Alignment is completely changed for controls under "Keyboard >> shortcuts" options. >> >> Please update the documentation as well after above changes. >> >> On Mon, Nov 2, 2020 at 1:55 PM Nikhil Mohite < >> nikhil.moh...@enterprisedb.com> wrote: >> >>> Hi Team, >>> >>> Please find the patch for RM-4231 >>> <https://redmine.postgresql.org/issues/4231>: Dynamically size tab >>> titles. >>> 1. Added "Tab settings" in browser preferences. >>> 2. Added setting to enable dynamic tab size in Tab settings. >>> 3. Moved the following tab related setting into Tab setting. >>> >>> - Open in a new browser tab: For query tool, debugger, and schema >>> diff. >>> - Placeholders for Query tool, View/Edit data, and Debugger. >>> >>> 4. Adde migration to remove older "open new tab browser tab" preferences >>> from the database. >>> 5. Updated the document as per new changes. >>> >>> Added small CSS fix for RM-5950 >>> <https://redmine.postgresql.org/issues/5950>: Long backup file name not >>> showing fully on process watcher dialog. >>> >>> >>> >>> -- >>> *Thanks & Regards,* >>> *Nikhil Mohite* >>> *Software Engineer.* >>> *EDB Postgres* <https://www.enterprisedb.com/> >>> *Mob.No: +91-7798364578.* >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> *pgAdmin Hacker | Principal Software Architect* >> *EDB Postgres <http://edbpostgres.com>* >> >> *Mobile: +91 976-788-8246* >> > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Principal Software Architect* *EDB Postgres <http://edbpostgres.com>* *Mobile: +91 976-788-8246*
