Hi, The imagemin-gifsicle package is used to compress gif images. The latest version of imagemin-gifsicle requires the binaries to be built from source, which has a big dependency of dh-autoreconf. pgAdmin has very few gifs. Instead of installing dh-autoreconf, I've removed imagemin-gifsicle from package.json since the cost of installing dh-autoreconf is more than the output of compressing gif. Attached is the patch.
On Wed, Feb 10, 2021 at 12:51 PM Akshay Joshi <akshay.jo...@enterprisedb.com> wrote: > Thanks, patch applied. > > On Wed, Feb 10, 2021 at 12:08 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi, >> >> On Tue, Feb 9, 2021 at 4:35 PM Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi Aditya >>> >>> One jasmine test is failing, please fix that and resend the patch. >>> >> It was failing because of a side effect of some other test case. Fixed. >> >> Please review. >> >>> >>> On Mon, Feb 8, 2021 at 5:07 PM Aditya Toshniwal < >>> aditya.toshni...@enterprisedb.com> wrote: >>> >>>> Hi Hackers, >>>> >>>> Attached is the patch to update the JS dependencies to latest. Changes >>>> include: >>>> 1) Migrate from webpack 4 to webpack 5. This had a lot of breaking >>>> changes, so updated multiple webpack plugins and changed the config >>>> accordingly. >>>> 2) Replaced iconfont-webpack-plugin with a more maintained >>>> webfonts-loader. >>>> 3) Replaced deprecated babel-eslint with @babel/eslint-parser >>>> 4) Replaced optimize-css-assets-webpack-plugin with a more maintained >>>> css-minimizer-webpack-plugin >>>> 5) Updated all other JS packages and made the required code changes. >>>> >>>> Note, there is an update available for slickgrid and I tried to update >>>> it. But it was not working as expected. So without wasting time, I've not >>>> updated slickgrid, and can be updated as a separate task. >>>> >>>> Please review. >>>> >>>> -- >>>> Thanks, >>>> Aditya Toshniwal >>>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* >>>> <http://edbpostgres.com> >>>> "Don't Complain about Heat, Plant a TREE" >>>> >>> >>> >>> -- >>> *Thanks & Regards* >>> *Akshay Joshi* >>> *pgAdmin Hacker | Principal Software Architect* >>> *EDB Postgres <http://edbpostgres.com>* >>> >>> *Mobile: +91 976-788-8246* >>> >> >> >> -- >> Thanks, >> Aditya Toshniwal >> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* >> <http://edbpostgres.com> >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > *pgAdmin Hacker | Principal Software Architect* > *EDB Postgres <http://edbpostgres.com>* > > *Mobile: +91 976-788-8246* > -- Thanks, Aditya Toshniwal pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* <http://edbpostgres.com> "Don't Complain about Heat, Plant a TREE"
RM6207.gifsicle.patch
Description: Binary data
