Fixed following code smells reported by SonarQube: 1) Boolean checks should not be inverted. 2) Review this redundant assignment. 3) Extract this nested ternary operation into an independent statement. 4) Unexpected empty function. 5) Immediately return this expression instead of assigning it to the temporary variable.
Branch ------ master Details ------- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e3807ec3d6718ecfc9c825feabdf4f31c06f0838 Modified Files -------------- .../servers/databases/casts/static/js/cast.js | 7 +++-- .../servers/databases/casts/static/js/cast.ui.js | 6 ++--- .../event_triggers/static/js/event_trigger.ui.js | 6 ++--- .../databases/extensions/static/js/extension.js | 5 ++-- .../databases/extensions/static/js/extension.ui.js | 3 +-- .../databases/languages/static/js/language.js | 3 +-- .../databases/languages/static/js/language.ui.js | 3 +-- .../publications/static/js/publication.js | 3 +-- .../schemas/aggregates/static/js/aggregate.js | 3 +-- .../schemas/collations/static/js/collation.js | 3 +-- .../foreign_tables/static/js/foreign_table.ui.js | 3 +-- .../schemas/functions/static/js/function.ui.js | 30 ++++++++++------------ .../functions/static/js/trigger_function.ui.js | 3 +-- .../schemas/operators/static/js/operator.js | 3 +-- .../schemas/packages/static/js/package.ui.js | 3 +-- .../tables/triggers/static/js/trigger.ui.js | 6 ++--- .../databases/schemas/types/static/js/type.ui.js | 5 ++-- .../databases/schemas/views/static/js/mview.ui.js | 6 ++--- .../databases/schemas/views/static/js/view.ui.js | 10 +++----- .../subscriptions/static/js/subscription.ui.js | 24 ++++++----------- .../pgagent/steps/static/js/pga_jobstep.ui.js | 3 +-- .../server_groups/servers/static/js/privilege.js | 2 +- .../server_groups/servers/static/js/server.js | 3 +-- .../server_groups/servers/static/js/server.ui.js | 26 +++++++------------ web/pgadmin/browser/static/js/node.ui.js | 2 +- .../js/sqleditor/new_connection_dialog_model.js | 5 ++-- web/pgadmin/static/vendor/backgrid/backgrid.js | 8 +++--- web/pgadmin/tools/backup/static/js/backup.ui.js | 3 +-- .../tools/backup/static/js/backupGlobal.ui.js | 3 +-- .../erd/static/js/erd_tool/dialogs/TableDialog.js | 2 +- web/pgadmin/tools/erd/static/js/erd_tool/index.js | 2 +- .../tools/grant_wizard/static/js/grant_wizard.js | 1 + .../static/js/import_export_selection.ui.js | 3 +-- .../static/js/import_export_servers.js | 1 + web/pgadmin/tools/restore/static/js/restore.ui.js | 3 +-- web/regression/javascript/erd/erd_core_spec.js | 2 +- web/regression/javascript/erd/fake_item.js | 14 +++++----- .../schema_ui_files/partition.utils.ui.spec.js | 4 +-- .../table/enable_disable_triggers_spec.js | 5 +++- 39 files changed, 91 insertions(+), 136 deletions(-)
