Fixed following code smells reported by SonarQube: 1) Immediately return this expression instead of assigning it to the temporary variable. 2) Extract this nested ternary operation into an independent statement. 3) Expected a `for-of` loop instead of a `for` loop with this simple iteration.
Branch ------ master Details ------- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9f836f54334ec0752a79f34d5527a695ed83476a Modified Files -------------- runtime/src/js/misc.js | 8 +-- .../index_constraint/static/js/primary_key.js | 6 +- web/pgadmin/browser/static/js/browser.js | 35 ++++++----- web/pgadmin/browser/static/js/collection.js | 5 +- web/pgadmin/browser/static/js/node.js | 17 ++++-- .../browser/static/js/quick_search/online_help.js | 4 +- .../static/js/quick_search/trigger_search.js | 1 - web/pgadmin/dashboard/static/js/Graphs.jsx | 8 +-- .../misc/dependencies/static/js/dependencies.js | 11 ++-- .../misc/dependents/static/js/dependents.js | 11 ++-- web/pgadmin/misc/static/explain/js/explain.js | 50 ++++++++++++---- .../misc/statistics/static/js/statistics.js | 8 ++- web/pgadmin/static/js/SchemaView/DataGridView.jsx | 6 +- web/pgadmin/static/js/SchemaView/FormView.jsx | 10 +++- web/pgadmin/static/js/alertify.pgadmin.defaults.js | 13 ++-- web/pgadmin/static/js/api_instance.js | 3 +- web/pgadmin/static/js/backform.pgadmin.js | 39 ++++++++---- web/pgadmin/static/js/backgrid.pgadmin.js | 37 +++++++----- web/pgadmin/static/js/check_node_visibility.js | 4 +- .../codemirror/addon/fold/pgadmin-sqlfoldcode.js | 3 +- .../static/js/components/FormComponents.jsx | 10 +++- web/pgadmin/static/js/components/PgTable.jsx | 3 +- .../static/js/selection/active_cell_capture.js | 4 +- web/pgadmin/static/js/selection/clipboard.js | 3 +- web/pgadmin/static/js/selection/column_selector.js | 3 +- web/pgadmin/static/js/selection/grid_selector.js | 4 +- web/pgadmin/static/js/selection/row_selector.js | 4 +- web/pgadmin/static/js/selection/set_staged_rows.js | 6 +- .../static/js/selection/xcell_selection_model.js | 11 ++-- web/pgadmin/static/js/size_prettify.js | 4 +- .../js/slickgrid/plugins/slick.autocolumnsize.js | 4 +- web/pgadmin/static/js/sqleditor/execute_query.js | 3 +- .../static/js/sqleditor/filter_dialog_model.js | 3 +- web/pgadmin/static/js/sqleditor/geometry_viewer.js | 3 +- web/pgadmin/static/js/sqleditor/macro_model.js | 7 +-- .../static/js/sqleditor/query_tool_actions.js | 2 +- web/pgadmin/static/js/tree/tree.js | 5 +- web/pgadmin/static/vendor/backgrid/backgrid.js | 70 +++++++++++----------- web/pgadmin/tools/backup/static/js/backup.js | 6 +- web/pgadmin/tools/datagrid/static/js/datagrid.js | 18 +++--- .../datagrid/static/js/datagrid_panel_title.js | 4 +- web/pgadmin/tools/datagrid/static/js/show_data.js | 5 +- .../tools/datagrid/static/js/show_query_tool.js | 3 +- web/pgadmin/tools/debugger/static/js/debugger.js | 8 +-- .../tools/debugger/static/js/debugger_ui.js | 8 +-- .../tools/debugger/static/js/debugger_utils.js | 12 ++++ web/pgadmin/tools/debugger/static/js/direct.js | 46 +++++++------- web/pgadmin/tools/erd/static/js/erd_module.js | 3 +- .../js/erd_tool/ui_components/BodyWidget.jsx | 7 +-- .../tools/grant_wizard/static/js/GrantWizard.jsx | 7 ++- .../tools/grant_wizard/static/js/grant_wizard.js | 6 +- .../tools/maintenance/static/js/maintenance.js | 8 +-- web/pgadmin/tools/psql/static/js/psql_module.js | 4 +- web/pgadmin/tools/restore/static/js/restore.js | 7 +-- .../tools/schema_diff/static/js/schema_diff_ui.js | 26 ++++---- .../static/js/search_objects_dialog_wrapper.js | 6 +- web/pgadmin/tools/sqleditor/static/js/sqleditor.js | 32 +++++----- web/regression/javascript/browser/layout_spec.js | 12 ++-- web/regression/javascript/fake_theme.js | 4 +- web/regression/javascript/tree/tree_fake.js | 8 ++- web/webpack.config.js | 14 ++--- web/webpack.shim.js | 4 +- 62 files changed, 367 insertions(+), 319 deletions(-)
