That’s great. I am suggesting the attached change.
In terms of test coverage, the change is already covered by existing LDAP connection tests. As far as I can see it’s not immediately possible to “sharpen” the existing tests to detect the bug I am trying to fix, as this would require a change not on the pgadmin side, but on the side of the LDAP server being used in the tests – but I am happy to have another look at that if I have misunderstood how those work. Cheers, Christoph From: Aditya Toshniwal <aditya.toshni...@enterprisedb.com> Sent: Mittwoch, 9. Februar 2022 05:05 To: Charlet, Christoph <christoph.char...@d-fine.de> Cc: pgadmin-hack...@postgresql.org Subject: Re: Bug #6991 - Suggestion to Contribute Fix Hi Christoph, Yes you can share the patch here. pgAdmin team can review and commit. :) On Wed, Feb 9, 2022 at 1:43 AM Charlet, Christoph <christoph.char...@d-fine.de<mailto:christoph.char...@d-fine.de>> wrote: Hi Guys, I created a ticket a while back (#6991<https://redmine.postgresql.org/issues/6991>), and as the change required to fix this is (afaiks) rather small, I’d be happy to contribute the fix we are currently using for our purposes. Any thoughts? Cheers, Christoph Please do not print this document unless it is necessary, consider the environment. d-fine GmbH: Sitz der Gesellschaft: An der Hauptwache 7, 60313 Frankfurt am Main; Amtsgericht Frankfurt am Main: HRB Nr. 48 103; Geschaeftsfuehrer: Dr. Florian Baumann, Christoph Belafi, Dr. Christoph Bennemann, Dr. Oliver Bohr, Dr. Christoph Burmester, Dr. Ashot Davtyan, Todor Dobrikov, Dr. Arndt Dombert, Dr. Uwe Doerr, Dr. Andreas Geyer, Nadine Gottschalk, Dr. Oliver Hein, Dr. Stefan Heinrichs, Dr. Matthias Hirtschulz, Dr. Bodo Huckestein, Dr. Sascha Huegle, Dr. Tilman Huhne, Jens Itzenhaeuser, Ulf Henning Jacobs, Dr. Jan Jureit, Dr. Oliver Kayser-Herold, Dr. Andreas Keese, Dr. Henriette Kroener, Dr. Florian Merz, Dr. Jochen Meyer, Dr. Karsten Meyer, Dr. Mathias Michel, Dr. Cornelius Mund, Dr. Christian Oehler, Wolfgang Pleyer, Dr. Joern Rank, Dr. Christian Romeike, Markus von Rothkirch, Alexander Schalk, Dr. Egbert Schark, Dr. Christoph Schneggenburger, Nadja Schuster, Dr. Markus Seifert, Dr. Constantin Sobiella, Artur Steiner, Dr. Roland Uhlig, Dr. Hans Peter Waechter, Dr. Andreas Werner, Dr. Magnus Wobben This e-mail communication (and any attachment/s) is confidential and intended only for the individual(s) or entity named above and to others who have been specifically authorized to receive it. If you are not the intended recipient, please do not read, copy, use or disclose the contents of this communication to others. Please notify the sender that you have received this e-mail in error, and delete the e-mail (including any attachment/s) subsequently. This information may be subject to professional secrecy (e. g. of auditor, tax or legal advisor), other privilege or otherwise be protected by work product immunity or other legal rules. For more information about how and why we use personal information and who to contact with any queries about this, please consult our Data Privacy Policy on https://www.d-fine.com/en_DE/privacy-policy/. Thank you. -- Thanks, Aditya Toshniwal pgAdmin Hacker | Software Architect | edbpostgres.com<http://edbpostgres.com> "Don't Complain about Heat, Plant a TREE" Please do not print this document unless it is necessary, consider the environment. d-fine GmbH: Sitz der Gesellschaft: An der Hauptwache 7, 60313 Frankfurt am Main; Amtsgericht Frankfurt am Main: HRB Nr. 48 103; Geschaeftsfuehrer: Dr. Florian Baumann, Christoph Belafi, Dr. Christoph Bennemann, Dr. Oliver Bohr, Dr. Christoph Burmester, Dr. Ashot Davtyan, Todor Dobrikov, Dr. Arndt Dombert, Dr. Uwe Doerr, Dr. Andreas Geyer, Nadine Gottschalk, Dr. Oliver Hein, Dr. Stefan Heinrichs, Dr. Matthias Hirtschulz, Dr. Bodo Huckestein, Dr. Sascha Huegle, Dr. Tilman Huhne, Jens Itzenhaeuser, Ulf Henning Jacobs, Dr. Jan Jureit, Dr. Oliver Kayser-Herold, Dr. Andreas Keese, Dr. Henriette Kroener, Dr. Florian Merz, Dr. Jochen Meyer, Dr. Karsten Meyer, Dr. Mathias Michel, Dr. Cornelius Mund, Dr. Christian Oehler, Wolfgang Pleyer, Dr. Joern Rank, Dr. Christian Romeike, Markus von Rothkirch, Alexander Schalk, Dr. Egbert Schark, Dr. Christoph Schneggenburger, Nadja Schuster, Dr. Markus Seifert, Dr. Constantin Sobiella, Artur Steiner, Dr. Roland Uhlig, Dr. Hans Peter Waechter, Dr. Andreas Werner, Dr. Magnus Wobben This e-mail communication (and any attachment/s) is confidential and intended only for the individual(s) or entity named above and to others who have been specifically authorized to receive it. If you are not the intended recipient, please do not read, copy, use or disclose the contents of this communication to others. Please notify the sender that you have received this e-mail in error, and delete the e-mail (including any attachment/s) subsequently. This information may be subject to professional secrecy (e. g. of auditor, tax or legal advisor), other privilege or otherwise be protected by work product immunity or other legal rules. For more information about how and why we use personal information and who to contact with any queries about this, please consult our Data Privacy Policy on https://www.d-fine.com/en_DE/privacy-policy/. Thank you.
bug_6991.diff
Description: bug_6991.diff
