Thanks, the patch applied On Fri, Mar 11, 2022 at 2:12 PM Akshay Joshi <akshay.jo...@enterprisedb.com> wrote:
> Isn't it possible to define it at a common location? These types of > duplicate code are error-prone since sometimes we fix an issue at one place > and forget to fix it at another. > > On Fri, Mar 11, 2022 at 11:56 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> One is for pgacloud standalone code for background process and one for >> pgadmin module. >> >> On Fri, 11 Mar 2022, 10:11 Akshay Joshi, <akshay.jo...@enterprisedb.com> >> wrote: >> >>> Hi Khushboo >>> >>> Why there are two identical functions (def get_my_ip) in two different >>> files, can you please make it generic in one place only and send the patch. >>> >>> On Fri, Mar 11, 2022 at 9:22 AM Yogesh Mahajan < >>> yogesh.maha...@enterprisedb.com> wrote: >>> >>>> Hi, >>>> >>>> Patch looks fine. IP Addresses are prefixed by 32 and 128 for IPv4 and >>>> IPv6 respectively. >>>> >>>> Thanks, >>>> Yogesh Mahajan >>>> EnterpriseDB >>>> >>>> >>>> On Fri, Mar 11, 2022 at 8:49 AM Khushboo Vashi < >>>> khushboo.va...@enterprisedb.com> wrote: >>>> >>>>> Hi, >>>>> >>>>> Please find the attached patch to fix the default Public IP range >>>>> issue in AWS deployment. >>>>> >>>>> @Yogesh Mahajan <yogesh.maha...@enterprisedb.com>, please test. >>>>> >>>>> >>>>> Thanks, >>>>> Khushboo >>>>> >>>> >>> >>> -- >>> *Thanks & Regards* >>> *Akshay Joshi* >>> *pgAdmin Hacker | Principal Software Architect* >>> *EDB Postgres <http://edbpostgres.com>* >>> >>> *Mobile: +91 976-788-8246* >>> >> > > -- > *Thanks & Regards* > *Akshay Joshi* > *pgAdmin Hacker | Principal Software Architect* > *EDB Postgres <http://edbpostgres.com>* > > *Mobile: +91 976-788-8246* > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Principal Software Architect* *EDB Postgres <http://edbpostgres.com>* *Mobile: +91 976-788-8246*
