Thanks, the patch applied. Screenshots are still not the latest. Take all the screenshots with the latest changes and send them back.
On Mon, Mar 21, 2022 at 10:00 AM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Akshay, > > PFA patch v2 resolved all the review comments. > > On Wed, Mar 9, 2022 at 5:48 PM Akshay Joshi <akshay.jo...@enterprisedb.com> > wrote: > >> Hi Nikhil >> >> Below are the review comments: >> *GUI:* >> >> - By default, all nodes should be expanded, and at least one node >> should be selected (Check existing behavior). >> - Reduce the space between the expand/collapse (>) icon and the >> tress node label. It is most likely icons that are taking up that space. >> - Unable to select parent node. With old behavior when we select the >> parent node its immediate first child is selected and the appropriate page >> is displayed on the right side. >> - The maximize button should be consistent with all other dialogs. >> - Maximize not working properly, move the dialog bit up, and then >> click Maximize button, dialog is not visible correctly. >> - The help button is missing at the bottom. >> - A documentation update is missing. >> - Keyboard Shortcuts (Browser, Debugger, Query Tool, and ERD Tool) *Fix >> for all* >> - Between the 'Key' label and control, there should be a margin. >> - Reduce the width of the key control. >> - The key control loses focus when the key is pressed. Verify old >> behavior. >> - Nodes: Can we add a message or label at the top about settings? >> Previously, we had a switch control with a 'Show/Hide' label that was >> clear >> to the end-user. >> - Dashboard -> Display -> Long-running query thresholds: >> - Between the 'Warning'/'Alert' label and their control, there >> should be a margin. >> - There is no '*in minutes*' label at the end. >> - Miscellaneous -> Themes: Themes preview is not visible. >> - Binary Paths: >> - 'Set as default' should be disabled until a path is provided. >> - 'Set as default' must be a radio button, only one binary path >> can be set to default not all. >> - Unable to select binary path as select dialog is hidden behind >> the preferences dialog. It seems the preferences dialog is the modal >> dialog. >> - Adjust the validation icon properly, space should not be there >> at the end. >> - [image: Screenshot 2022-03-09 at 4.34.08 PM.png] >> - Query Tool: CSV/TXT Output node should be after Auto completion. >> - Browser -> Tab settings and Storage -> Options have identical right >> side page. Remove the controls appropriately. >> >> I tried but was unable to reproduce the issue. > >> >> *Code:* >> >> - Add comments/function header for all the new functions created. >> >> >> On Mon, Mar 7, 2022 at 5:54 PM Nikhil Mohite < >> nikhil.moh...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Please find attached the patch for RM-7149 >>> <https://redmine.postgresql.org/issues/7149>: [React] Port preferences >>> dialog to React. >>> >>> -- >>> *Thanks & Regards,* >>> *Nikhil Mohite* >>> *Senior Software Engineer.* >>> *EDB Postgres* <https://www.enterprisedb.com/> >>> *Mob.No: +91-7798364578.* >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> *pgAdmin Hacker | Principal Software Architect* >> *EDB Postgres <http://edbpostgres.com>* >> >> *Mobile: +91 976-788-8246* >> > > Regards, > Nikhil Mohite > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Principal Software Architect* *EDB Postgres <http://edbpostgres.com>* *Mobile: +91 976-788-8246*
