Hi Akshay, PFA patch for fixing the following issue in debugger. 1. If debugger arguments are array debugger sets the *null* value to parameters. 2. Popup screen is not being closed if debug Package procedure/Function and select *Null* option. 3. Updated validation for debugger argument of the array type parameter.
On Wed, Jun 15, 2022 at 11:39 AM Akshay Joshi <akshay.jo...@enterprisedb.com> wrote: > Thanks, the patch applied. > > On Tue, Jun 14, 2022 at 6:09 PM Nikhil Mohite < > nikhil.moh...@enterprisedb.com> wrote: > >> Hi Akshay, >> >> PFA patch v2, fixed all review comments. >> >> On Thu, Jun 9, 2022 at 4:53 PM Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi Nikhil >>> >>> Following are the review comments: >>> >>> *GUI:* >>> >>> - *Parameter dialog*: >>> - Get the warning when parameter dialog gets opened Warning: >>> [JSS] Could not find the referenced rule "disabled" in "makeStyles". >>> - Debug button should not be enabled until all the required >>> parameters value is not entered by the user. (Check the existing >>> behavior) >>> - OK, button not working on the 'Debugger Error' popup. >>> - The 'Use Default' checkbox should be disabled if the default >>> value is not available for the parameter. (Check existing behavior.) >>> - Sometimes the value of the few parameters does not persist for >>> the next run. >>> >>> Done. >> >>> >>> - *Debugger Panel*: >>> - Fix 'Error while selecting frame.' error when clicking on the >>> Line no of the 'stack' tab. Stop all the API calls when execution is >>> completed. >>> - Set Breakpoint not working. getting 'Error while clearing all >>> breakpoint.' error on frontend and "UnboundLocalError: local variable >>> 'line_numbers' referenced before assignment" error on the backend. >>> - 'Debugger aborted successfully' message should be displayed in >>> notistack when the user aborts the debugger execution. (Check the >>> existing >>> behavior) >>> >>> Done. >> >>> *Code:* >>> >>> - Jasmine test cases are failing. Check the feature test as well. >>> - Remove "debugger;" from the "direct.html" file. >>> - Remove commented code from the "debugger/__init__.py" and >>> "index.js" files. Also, remove the below else condition from >>> "debugger/__init__.py" which is of no use >>> >>> else: >>> >>> [] >>> >>> >>> - Remove a few extra lines at the end of the "DebuggerModule.js". >>> - Add copyright header to "DebuggerArgs.ui.js", "ToolBar.jsx" and >>> "MockDebuggerComponent.jsx". >>> - Fixed SonarQube issues from "DebuggerArgumentComponent.jsx", >>> "DebuggerComponent.jsx". >>> >>> Done. >> >>> >>> On Wed, Jun 8, 2022 at 2:28 PM Nikhil Mohite < >>> nikhil.moh...@enterprisedb.com> wrote: >>> >>>> Hi Hackers, >>>> >>>> Please find attached the patch for RM-6132 >>>> <https://redmine.postgresql.org/issues/6132>: [React] Port debugger to >>>> React >>>> >>>> >>>> -- >>>> *Thanks & Regards,* >>>> *Nikhil Mohite* >>>> *Senior Software Engineer.* >>>> *EDB Postgres* <https://www.enterprisedb.com/> >>>> *Mob.No: +91-7798364578.* >>>> >>> >>> >>> -- >>> >>> <http://www.enterprisedb.com> >>> >>> Akshay Joshi >>> >>> Principal Software Architect >>> >>> +91 9767888246 >>> >>> www.enterprisedb.com >>> >>> <https://www.linkedin.com/company/edbpostgres> >>> <https://twitter.com/edbpostgres?lang=en> >>> <https://www.facebook.com/EDBpostgres> >>> <https://www.instagram.com/EDBpostgres/> >>> >> >> Regards, >> Nikhil Mohite >> > > > -- > > <http://www.enterprisedb.com> > > Akshay Joshi > > Principal Software Architect > > +91 9767888246 > > www.enterprisedb.com > > <https://www.linkedin.com/company/edbpostgres> > <https://twitter.com/edbpostgres?lang=en> > <https://www.facebook.com/EDBpostgres> > <https://www.instagram.com/EDBpostgres/> > Regards, Nikhil Mohite
RM-6132_v3.patch
Description: Binary data
