Thanks, the patch applied. On Mon, Jul 25, 2022 at 11:22 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote:
> Hi, > > Attached patch fixes: > 1. Intermittently failing test cases. > 2. Dialog vertical position should be more on the upper side. > 3. File not supported error is not showing. > > Please review. > > On Tue, Jul 19, 2022 at 3:30 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Thanks, the patch applied. >> >> On Mon, Jul 18, 2022 at 6:09 PM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi Akshay, >>> >>> Please find the updated patch and inline comments. >>> >>> On Thu, Jul 14, 2022 at 5:23 PM Akshay Joshi < >>> akshay.jo...@enterprisedb.com> wrote: >>> >>>> Hi Aditya >>>> >>>> Following are the review comments: >>>> >>>> GUI: >>>> >>>> - By default files/folders are not visible. >>>> >>>> Fixed. >>> >>>> >>>> - The select button should be disabled until the file/folder is not >>>> selected, to reproduce open the dialog select any file, and then change >>>> the >>>> file format, the select button should be disabled. In one more scenario >>>> open the Restore dialog and select any file in the file manager dialog, >>>> and >>>> click on the 'Delete' option, Select button is enabled and if we click >>>> on >>>> its file name 'null' is displayed. >>>> >>>> Fixed. >>> >>>> >>>> - The select folder should not have the 'File Format' option, check >>>> the existing behavior. You can check Preferences -> Path -> Binary >>>> Path. >>>> >>>> Removed. >>> >>>> >>>> - >>>> - The file should save/create with an extension, open the query >>>> tool, and try to save the SQL with file format as 'sql'. >>>> >>>> Fixed. >>> >>>> >>>> - The save button should be enabled if select the existing file in >>>> the Save file dialog. Open the Query tool and type some query, try to >>>> save >>>> it, and select the existing file, Save button is disabled. >>>> >>>> Fixed. Once a user clicks on any file, the file name will be set in the >>> Save As text box (Similar to Mac finder). If the user then clicks Save then >>> the file replace sequence will follow if there is no change in save as text >>> box. >>> >>>> >>>> - Storage Manager >>>> - Download, Rename, Delete button should be disabled if no file >>>> is selected. Reproduction step, open storage manager dialog, and >>>> change the >>>> file format to 'All files'. If already it is 'All files' then change >>>> to >>>> something else and again select 'All files'. >>>> >>>> Fixed. >>> >>> >>>> - File drop should be applied only to the marked area not the >>>> complete storage/file manager dialog. Currently, the drop icon is not >>>> changing if the user tries to drop the file on the rest of the area. >>>> >>>> The icon is set by the OS when dragging. We do not have control over >>> that. >>> >>>> >>>> - Delete file/folder option, we should ask for confirmation before >>>> deleting the file or folder directly. >>>> >>>> Done. >>> >>>> >>>> - Uploading the same file multiple times shows the same name on the >>>> right side with multiple entries, but on disk, there is only one file >>>> uploaded. Users should be able to upload the same file multiple >>>> times. >>>> Thoughts? >>>> >>>> The current behaviour replaces the file. The upload UI is just to show >>> the progress of upload and whether it was successful or failure. It doesn't >>> say about the files on the storage. >>> >>>> >>>> - Uploading the same file 2 times and trying to delete the file >>>> using the delete button on the right-side panel. it throws an error >>>> on the >>>> browser. >>>> >>>> I have removed the delete button from uploads. Since we can delete from >>> the file manager, there is no need to put the delete button there. Instead, >>> I have added a close button for each item which will remove the item from >>> the list. >>> >>>> >>>> - Create one folder ex: 'Testing Folder' select that and upload the >>>> same file 2 times, one file is uploaded in the same directory and the >>>> second one in the parent directory with the folder name prefixed to >>>> the >>>> file name. >>>> >>>> Fixed. >>> >>>> >>>> - Create two folders with the same name, as user experience, it >>>> shows both the folder has been created without showing any error, >>>> but when >>>> reopening the dialog or just changing the File format name of the one >>>> folder is changed to 'Untitled Folder'. We should throw an error >>>> 'Folder >>>> already exists. >>>> >>>> This is not reproducible at my end and works fine. Can you try again ? >>> >>>> >>>> - Import/Export Serevrs >>>> - Export: Create file dialog should have the primary button >>>> label 'Create'. >>>> - Export: File should be saved with extension ".json" >>>> - The file format is JSON, and the dialog shows other files as >>>> well. In short JSON filter is not applied, if the file manager >>>> dialog opens >>>> with 'All files' last time. >>>> >>>> Fixed >>> >>>> Code: >>>> >>>> - Remove print statement from 'config.py' >>>> >>>> Removed. >>> >>>> >>>> On Wed, Jul 13, 2022 at 6:15 PM Aditya Toshniwal < >>>> aditya.toshni...@enterprisedb.com> wrote: >>>> >>>>> Hi Hackers, >>>>> >>>>> Attached is the patch to: >>>>> >>>>> 1. Port the existing file dialog/storage manager to ReactJS and >>>>> major UI improvements. >>>>> 2. Use the native OS file dialog when pgAdmin runs in desktop mode. >>>>> 3. Allow users to search files in the current folder. Fixes #7389. >>>>> 4. Fix a bug where save Dialog can't create a new folder. Fixed >>>>> #7524. >>>>> 5. Allow users to delete files/folders. Fixes #4607. >>>>> 6. Add JS test cases and doc updates. >>>>> >>>>> Please review. >>>>> >>>>> -- >>>>> Thanks, >>>>> Aditya Toshniwal >>>>> pgAdmin Hacker | Software Architect | *edbpostgres.com* >>>>> <http://edbpostgres.com> >>>>> "Don't Complain about Heat, Plant a TREE" >>>>> >>>> >>>> >>>> -- >>>> >>>> <http://www.enterprisedb.com> >>>> >>>> Akshay Joshi >>>> >>>> Principal Software Architect >>>> >>>> +91 9767888246 >>>> >>>> www.enterprisedb.com >>>> >>>> <https://www.linkedin.com/company/edbpostgres> >>>> <https://twitter.com/edbpostgres?lang=en> >>>> <https://www.facebook.com/EDBpostgres> >>>> <https://www.instagram.com/EDBpostgres/> >>>> >>> >>> >>> -- >>> Thanks, >>> Aditya Toshniwal >>> pgAdmin Hacker | Software Architect | *edbpostgres.com* >>> <http://edbpostgres.com> >>> "Don't Complain about Heat, Plant a TREE" >>> >> >> >> -- >> >> <http://www.enterprisedb.com> >> >> Akshay Joshi >> >> Principal Software Architect >> >> +91 9767888246 >> >> www.enterprisedb.com >> >> <https://www.linkedin.com/company/edbpostgres> >> <https://twitter.com/edbpostgres?lang=en> >> <https://www.facebook.com/EDBpostgres> >> <https://www.instagram.com/EDBpostgres/> >> > > > -- > Thanks, > Aditya Toshniwal > pgAdmin Hacker | Software Architect | *edbpostgres.com* > <http://edbpostgres.com> > "Don't Complain about Heat, Plant a TREE" > -- <http://www.enterprisedb.com> Akshay Joshi Principal Software Architect +91 9767888246 www.enterprisedb.com <https://www.linkedin.com/company/edbpostgres> <https://twitter.com/edbpostgres?lang=en> <https://www.facebook.com/EDBpostgres> <https://www.instagram.com/EDBpostgres/>
