Hi Khushboo

Following are the review comments:

   - Remove psycopg2 from requirements.txt
   - Set PG_DEFAULT_DRIVER to psycopg3 in config.py
   - Remove all the imports of 'psycopg2' from the entire project.
   - Query Tool not working with psycopg3 == 3.1


On Tue, Aug 30, 2022 at 8:57 PM Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

> Hello,
>
> Please find the attached patch to migrate psycopg2 to psycopg3. I have
> used psycopg v 3.1.0 which is yet to be released soon. To test the patch,
> one needs to clone the psycopg3 repo, build it and point it to the pgadmin
> venv.
>
> For the time being, psycopg2 and psycopg3 both can be configurable  via 
> PG_DEFAULT_DRIVER
> and can be used.
>
> With this patch many SQL Ascii related issues and Range partition
> related issues are resolved. For example:  #7028, # 6575, #4061, #7165.
>
> I have verified some of them but we need to test all of them.
>
> Note: Debugger test cases are still failing, on which I am still working.
>
> Thanks,
> Khushboo
>


-- 

<http://www.enterprisedb.com>

Akshay Joshi

Principal Software Architect

+91 9767888246

www.enterprisedb.com

<https://www.linkedin.com/company/edbpostgres>
<https://twitter.com/edbpostgres?lang=en>
<https://www.facebook.com/EDBpostgres>
<https://www.instagram.com/EDBpostgres/>

Reply via email to