On Fri, 31 Mar 2023 at 14:03, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote:
> Hi, > > On Fri, Mar 31, 2023 at 6:22 PM Dave Page <dave.p...@enterprisedb.com> > wrote: > >> Hi >> >> On Fri, 31 Mar 2023 at 11:07, Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi Dave/Hackers, >>> >>> After thinking more about it, I now have a different proposal. We should >>> club all object related stuff under a single tab. >>> Basically, we can have one tab say - Object Info and under that tab we >>> will have sub tabs/layout - Summary, SQL, Statistics, Dependents and >>> Dependencies. Users can re-shuffle the tabs layout under the Object Info >>> tab as per choice. The advantage of this would be less cluttered tabs, more >>> space for other tabs and all object related tabs under one umbrella. >>> >>> To Summarise, the default tabs would be - Dashboard, Object Info, >>> Processes, <more tools as opened>... >>> >> >> Well that won't happen for 7.0... >> >> I'm not entirely against the idea, but it's one of those things that I >> think I'd want to see before committing to. I can envisage what it would >> look like, but not how it would feel to use. >> > Then I should probably revert the "Edit Object..." back to "Properties..." > as before until decide on something. > Yes. This is definitely too big of a change to do the Friday before a release. We have enough regressions to fix already anyway. > >> >>> >>> Thoughts? >>> >>> >>> On Wed, Mar 29, 2023 at 4:24 PM Aditya Toshniwal < >>> aditya.toshni...@enterprisedb.com> wrote: >>> >>>> Hi Dave, >>>> >>>> On Wed, Mar 29, 2023 at 3:59 PM Dave Page <dave.p...@enterprisedb.com> >>>> wrote: >>>> >>>>> >>>>> >>>>> On Wed, 29 Mar 2023 at 11:11, Aditya Toshniwal < >>>>> aditya.toshni...@enterprisedb.com> wrote: >>>>> >>>>>> Hi Hackers, >>>>>> >>>>>> One of the users had raised a concern regarding confusing >>>>>> "Properties" label - one on the tab (read only) and another one on >>>>>> context(to edit) - >>>>>> https://github.com/pgadmin-org/pgadmin4/issues/4734. We are using >>>>>> the label "Edit the object" on the Edit button of the properties tab >>>>>> already. >>>>>> So I suggest we should rename the context "Properties..." to "Edit >>>>>> Object..." >>>>>> for consistency as well as to make it more meaningful. >>>>>> >>>>>> Thoughts? >>>>>> >>>>> >>>>> I disagree. "Properties" is the standard name for that type of >>>>> dialogue throughout Windows and many/most Linux windowing systems (e.g. >>>>> Gnome). On macOS, the equivalent is "Get Info". I don't think we should >>>>> deviate from a few decades of use of that name based on a single ticket >>>>> (if >>>>> anything, maybe we should make it say "Get Info" when the UI is displayed >>>>> on a mac). >>>>> >>>>> Dave's point in his bug report is mostly that we also use the term >>>>> "Properties" for the panel in the main UI in which we display some >>>>> properties (but not all, and sometimes extra, over what is in the >>>>> dialogue). I would not object to renaming that panel to "Object Summary" >>>>> or >>>>> similar, to correspond with "Object Explorer". >>>>> >>>>> Which then leads to another thought - we've used one-word naming in >>>>> the past for tabs. We now have "Object Explorer", and I just suggested >>>>> "Object Summary" - but those imply we should also have "Object >>>>> Dependencies", "Object Dependents", and "Object SQL", which I definitely >>>>> do >>>>> not like. >>>>> >>>>> So maybe everything should have a one word label? >>>>> >>>> I am fine with renaming the tab instead of the context menu. We can >>>> rename the "Properties" tab to just "Summary"/"Info" and everything works >>>> as before. We don't need to add "Object" to tabs. >>>> >>>>> >>>>> -- >>>>> Dave Page >>>>> VP, Chief Architect, Database Infrastructure >>>>> Blog: https://www.enterprisedb.com/dave-page >>>>> Twitter: @pgsnake >>>>> >>>>> EDB: https://www.enterprisedb.com >>>>> >>>> >>>> >>>> -- >>>> Thanks, >>>> Aditya Toshniwal >>>> pgAdmin Hacker | Software Architect | *edbpostgres.com* >>>> <http://edbpostgres.com> >>>> "Don't Complain about Heat, Plant a TREE" >>>> >>> >>> >>> -- >>> Thanks, >>> Aditya Toshniwal >>> pgAdmin Hacker | Software Architect | *edbpostgres.com* >>> <http://edbpostgres.com> >>> "Don't Complain about Heat, Plant a TREE" >>> >> >> >> -- >> Dave Page >> VP, Chief Architect, Database Infrastructure >> Blog: https://www.enterprisedb.com/dave-page >> Twitter: @pgsnake >> >> EDB: https://www.enterprisedb.com >> > > > -- > Thanks, > Aditya Toshniwal > pgAdmin Hacker | Software Architect | *edbpostgres.com* > <http://edbpostgres.com> > "Don't Complain about Heat, Plant a TREE" > -- Dave Page VP, Chief Architect, Database Infrastructure Blog: https://www.enterprisedb.com/dave-page Twitter: @pgsnake EDB: https://www.enterprisedb.com
