Hi Rohit, It is actually the same as existing with only difference is alternate row backgrounds. If later we remove the alternate bg using preferences then issue of distinguishing row numbers will remain un-fixed.
On Tue, Sep 10, 2024 at 5:41 PM Rohit Bhati <rohit.bh...@enterprisedb.com> wrote: > Ok, I am applying that. > > Thanks for the suggestions. > > On Tue, Sep 10, 2024 at 5:34 PM Dave Page <dp...@pgadmin.org> wrote: > >> Hi >> >> >> On Tue, 10 Sep 2024 at 12:43, Rohit Bhati <rohit.bh...@enterprisedb.com> >> wrote: >> >>> Hi Dave, >>> >>> I have made some changes and made the header and serial number row >>> column color the same. >>> >>> Please once check the attached images. >>> >> >> I think that looks much better! >> >> Thanks. >> >> >>> >>> Thanks >>> >>> On Tue, Sep 10, 2024 at 2:42 PM Dave Page <dp...@pgadmin.org> wrote: >>> >>>> Hi >>>> >>>> Shadow is more visible, but it doesn't really follow the material UI >>>> styling which is flat rather than 3D. >>>> >>>> I think Anil's idea is worth exploring; remove the alternating colour >>>> for the row number column, and use a different background shade for it >>>> entirely. >>>> >>>> On Tue, 10 Sept 2024 at 08:38, Rohit Bhati < >>>> rohit.bh...@enterprisedb.com> wrote: >>>> >>>>> Hi Dave, >>>>> >>>>> I have added shadow to make the text more distinct and attached >>>>> screenshots based on themes. >>>>> Please once check and let me know if we can go ahead with this or >>>>> provide suggestions if need to make changes. >>>>> >>>>> Thanks & Regards >>>>> Rohit Bhati >>>>> >>>>> >>>>> On Mon, Sep 9, 2024 at 4:11 PM Rohit Bhati < >>>>> rohit.bh...@enterprisedb.com> wrote: >>>>> >>>>>> I already set weight to 900. >>>>>> If we need to be more distinct then I think we can have some shadow >>>>>> or if anything else please suggest. >>>>>> >>>>>> On Mon, Sep 9, 2024 at 3:29 PM Dave Page <dp...@pgadmin.org> wrote: >>>>>> >>>>>>> Hi >>>>>>> >>>>>>> On Mon, 9 Sept 2024 at 10:18, Rohit Bhati < >>>>>>> rohit.bh...@enterprisedb.com> wrote: >>>>>>> >>>>>>>> Hi Dave, >>>>>>>> >>>>>>>> I have made changes as per your suggestions. >>>>>>>> I have attached screenshots showing how the updates look across all >>>>>>>> themes for your reference. >>>>>>>> >>>>>>>> If the current changes does not fit well with the theme or if you >>>>>>>> have any suggestions for improvements, please let me know. >>>>>>>> >>>>>>> >>>>>>> The colours etc. look correct now (ie. there are no weird borders), >>>>>>> but I still don't think the row number looks visually distinct from the >>>>>>> rest of the data. The bold text simply isn't very bold - I think it >>>>>>> still >>>>>>> needs more weight. >>>>>>> >>>>>>> >>>>>>> >>>>>>>> >>>>>>>> Thanks >>>>>>>> Rohit Bhati >>>>>>>> EnterpriseDB >>>>>>>> >>>>>>>> >>>>>>>> On Fri, Sep 6, 2024 at 2:01 PM Dave Page <dp...@pgadmin.org> wrote: >>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> On Fri, 6 Sept 2024 at 09:25, Rohit Bhati < >>>>>>>>> rohit.bh...@enterprisedb.com> wrote: >>>>>>>>> >>>>>>>>>> I have made some more changes with changing background color. >>>>>>>>>> >>>>>>>>> >>>>>>>>> Yeah, that looks weird again, specifically on the selected rows. I >>>>>>>>> believe the issue is that we should not highlight the row number >>>>>>>>> column >>>>>>>>> when a row is selected at all. That makes sense, as we should only be >>>>>>>>> highlighting the columns that would get copied in a copy/paste >>>>>>>>> operation >>>>>>>>> anyway. >>>>>>>>> >>>>>>>>> Also, the bold still doesn't look bold. I think the weight needs >>>>>>>>> to be increased. >>>>>>>>> >>>>>>>>> >>>>>>>>>> >>>>>>>>>> I have attached screenshots showing how the updates look across >>>>>>>>>> all themes. >>>>>>>>>> >>>>>>>>>> On Fri, Sep 6, 2024 at 1:51 PM Dave Page <dp...@pgadmin.org> >>>>>>>>>> wrote: >>>>>>>>>> >>>>>>>>>>> Hi >>>>>>>>>>> >>>>>>>>>>> On Fri, 6 Sept 2024 at 09:19, Rohit Bhati < >>>>>>>>>>> rohit.bh...@enterprisedb.com> wrote: >>>>>>>>>>> >>>>>>>>>>>> Hi, >>>>>>>>>>>> >>>>>>>>>>>> I have removed the border and background color, just made the row >>>>>>>>>>>> numbers bold. >>>>>>>>>>>> >>>>>>>>>>>> I have attached screenshots showing how the updates look across >>>>>>>>>>>> all themes. >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> That doesn't look bold at all to me - and I think we still need >>>>>>>>>>> some other visual distinction, such as the column background colour. >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> On Fri, Sep 6, 2024 at 12:35 PM Khushboo Vashi < >>>>>>>>>>>> khushboo.va...@enterprisedb.com> wrote: >>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> On Thu, Sep 5, 2024 at 7:11 PM Dave Page <dp...@pgadmin.org> >>>>>>>>>>>>> wrote: >>>>>>>>>>>>> >>>>>>>>>>>>>> Hi >>>>>>>>>>>>>> >>>>>>>>>>>>>> On Thu, 5 Sept 2024 at 14:38, Rohit Bhati < >>>>>>>>>>>>>> rohit.bh...@enterprisedb.com> wrote: >>>>>>>>>>>>>> >>>>>>>>>>>>>>> Hi, >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> I have made changes for issue #7863 >>>>>>>>>>>>>>> <https://github.com/pgadmin-org/pgadmin4/issues/7863> based >>>>>>>>>>>>>>> on theme requirements. >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> I have attached screenshots showing how the updates look >>>>>>>>>>>>>>> across all themes for your reference. >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> If the current color does not fit well with the theme or if >>>>>>>>>>>>>>> you have any suggestions for improvements, please let me know. >>>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> Is the colour contrast high enough on the row numbers for >>>>>>>>>>>>>> selected rows in the high contrast theme? The black on grey >>>>>>>>>>>>>> seems like it >>>>>>>>>>>>>> might not be to me, but I haven't tested. >>>>>>>>>>>>>> >>>>>>>>>>>>>> I wonder also if we should make the row numbers bold all the >>>>>>>>>>>>>> time. Thoughts? >>>>>>>>>>>>>> >>>>>>>>>>>>> We can check how it looks. Also the cell border doesn't look >>>>>>>>>>>>> good to me. >>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> -- >>>>>>>>>>>>>> Dave Page >>>>>>>>>>>>>> pgAdmin: https://www.pgadmin.org >>>>>>>>>>>>>> PostgreSQL: https://www.postgresql.org >>>>>>>>>>>>>> EDB: https://www.enterprisedb.com >>>>>>>>>>>>>> >>>>>>>>>>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/ >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> -- >>>>>>>>>>> Dave Page >>>>>>>>>>> pgAdmin: https://www.pgadmin.org >>>>>>>>>>> PostgreSQL: https://www.postgresql.org >>>>>>>>>>> EDB: https://www.enterprisedb.com >>>>>>>>>>> >>>>>>>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/ >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> Dave Page >>>>>>>>> pgAdmin: https://www.pgadmin.org >>>>>>>>> PostgreSQL: https://www.postgresql.org >>>>>>>>> EDB: https://www.enterprisedb.com >>>>>>>>> >>>>>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/ >>>>>>>>> >>>>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Dave Page >>>>>>> pgAdmin: https://www.pgadmin.org >>>>>>> PostgreSQL: https://www.postgresql.org >>>>>>> EDB: https://www.enterprisedb.com >>>>>>> >>>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/ >>>>>>> >>>>>>> >>>> >>>> -- >>>> Dave Page >>>> pgAdmin: https://www.pgadmin.org >>>> PostgreSQL: https://www.postgresql.org >>>> EDB: https://www.enterprisedb.com >>>> >>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/ >>>> >>>> -- Thanks, Aditya Toshniwal pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com* <https://www.enterprisedb.com/> "Don't Complain about Heat, Plant a TREE"
