Minor bug and suggested fix - 1.2 and 1.3.5

[Mark A. Taff]

<font size=2 color=black
face=Arial><span style='font-size:10.0pt;mso-bidi-font-size:12.0pt;font-family:
Arial'>All,

<font size=2 color=black
face=Arial><span style='font-size:10.0pt;mso-bidi-font-size:12.0pt;font-family:
Arial'>����������� I&#8217;ve
found a minor bug in 1.2 and 1.3.5. <span style="mso-spacerun:
yes">�When an uncorrected error occurs and LogError is called after
StartMsg has been called, EndMsg is not always called, and so the cursor does not
always return to a normal cursor.�
Rather than trying to check and correct for this throughout the code, I&#8217;ve
just done it once in the LogError sub.�
I&#8217;ve pasted patched code based on 1.3.5 for your consideration below.

<font size=2 color=black
face=Arial><span style='font-size:10.0pt;mso-bidi-font-size:12.0pt;font-family:
Arial'>�

<font size=2 color=black
face=Arial><span style='font-size:10.0pt;mso-bidi-font-size:12.0pt;font-family:
Arial'>Regards,

<font size=2 color=black
face=Arial><span style='font-size:10.0pt;mso-bidi-font-size:12.0pt;font-family:
Arial'>�

<font size=2 color=black
face=Arial><span style='font-size:10.0pt;mso-bidi-font-size:12.0pt;font-family:
Arial'>Mark Taff

<font size=2 color=black
face=Arial><span style='font-size:10.0pt;mso-bidi-font-size:12.0pt;font-family:
Arial'>�

<font size=2 color=black
face=Arial><span style='font-size:10.0pt;mso-bidi-font-size:12.0pt;font-family:
Arial'>*** Begin patch for pgAdmin2.basMisc.LogError v1.3.5 ***

<font size=2 color=black
face=Arial><span style='font-size:10.0pt;mso-bidi-font-size:12.0pt;font-family:
Arial'>�

<font size=2 color=black
face=Arial><span style='font-size:10.0pt;mso-bidi-font-size:12.0pt;font-family:
Arial'>Public Sub LogError(lError As Long, szError As String, szRoutine As
String)

<font size=2 color=black
face=Arial><span style='font-size:10.0pt;mso-bidi-font-size:12.0pt;font-family:
Arial'>'No logging here, if anythings going wrong then we want the real error

<font size=2 color=black
face=Arial><span style='font-size:10.0pt;mso-bidi-font-size:12.0pt;font-family:
Arial'>�

<font size=2 color=black
face=Arial><span style='font-size:10.0pt;mso-bidi-font-size:12.0pt;font-family:
Arial'>� frmMain.svr.LogEvent
"Error in " & szRoutine & ": " & lError &
" - " & szError, etErrors

<font size=2 color=black
face=Arial><span style='font-size:10.0pt;mso-bidi-font-size:12.0pt;font-family:
Arial'>� MsgBox "An error has
occured in " & szRoutine & ":" & vbCrLf & vbCrLf
& "Number: " & lError & vbCrLf & "Description:
" & szError, vbExclamation, App.Title & " Error"

<font size=2 color=black
face=Arial><span style='font-size:10.0pt;mso-bidi-font-size:12.0pt;font-family:
Arial'>� 

<font size=2 color=black
face=Arial><span style='font-size:10.0pt;mso-bidi-font-size:12.0pt;font-family:
Arial'>� 'If we get here, EndMsg
may not fire, so give the user a normal cursor...

<font size=2 color=black
face=Arial><span style='font-size:10.0pt;mso-bidi-font-size:12.0pt;font-family:
Arial'>� Screen.MousePointer =
vbDefault

<font size=2 color=black
face=Arial><span style='font-size:10.0pt;mso-bidi-font-size:12.0pt;font-family:
Arial'>� 

<font size=2 color=black
face=Arial><span style='font-size:10.0pt;mso-bidi-font-size:12.0pt;font-family:
Arial'>End Sub

<font size=2 color=black
face=Arial><span style='font-size:10.0pt;mso-bidi-font-size:12.0pt;font-family:
Arial'>�

<font size=2 color=black
face=Arial><span style='font-size:10.0pt;mso-bidi-font-size:12.0pt;font-family:
Arial'>*** End patch ***