Le Vendredi 22 F�vrier 2002 23:06, Dave Page a �crit : > 1) Don't create the view twice, create the fake one then rename it - it's > less expensive and avoids the potential for the second create to fail. OK
> 2) The szOldDefintion stuff can now be removed. OK > 3) The OID and Definition could be retrieved in one operation rather than > 2. OK > 4) A class library such as this should _never_ display any user interface. > That is the job of the application. OK > 5) The modifications to the SQL property are messy & mainly unnecessary > (certainly with #1 above - that just needs bDrop & szViewName). Will have a look at it tomorrow. I though interesting to write SQL using a single property. This is easier to maintain code. Don't flame me... > 6) The iLogEvent "Entering..." code should be immediately after the On > Error code, not in the middle of the function. OK > 7) The Comment cache is not being invalidated. OK \Later
