Re: [pgadmin-hackers] COMMENT ON FUNCTION

[Adam H. Pendleton]

Darko Prenosil wrote:

When function has arguments, for example :

	foo(varchar,int)

extracted metadata from pgadmin is:

COMMENT ON FUNCTION foo IS 'Comment';

which is wrong, it shoul'd be :

COMMENT ON FUNCTION foo(varchar,int) IS 'Comment';

Regards !

---------------------------(end of broadcast)---------------------------
TIP 1: subscribe and unsubscribe commands go to [EMAIL PROTECTED]
 

I thought I'd take a crack at this one, and pretend to be a real 
developer for a moment.  Here is a patch.

ahp
--- pgadmin3/src/ui/dlgFunction.cpp     2003-06-20 05:26:57.000000000 -0400
+++ pgadmin3.new/src/ui/dlgFunction.cpp 2003-07-02 13:11:20.000000000 -0400
@@ -381,6 +381,7 @@
         || (!function && !comment.IsEmpty()))
     {
         sql += wxT("COMMENT ON FUNCTION ") + name 
+            + wxT("(") + GetArgs(true) + wxT(")")
             + wxT(" IS ") + qtString(comment)
             + wxT(";\n");
     }
---------------------------(end of broadcast)---------------------------
TIP 6: Have you searched our list archives?
               http://archives.postgresql.org