-----Original Message-----
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Sent: 10 September 2004 10:03
To: [EMAIL PROTECTED]
Cc: [EMAIL PROTECTED]; Dave Page; [EMAIL PROTECTED]
Subject: Re: Re: [pgadmin-hackers] " keywords... Is it normal ?
Also add the user name in the grant statements.
I've read some thread implying Andreas and quoted keywords.
I think Andreas or Dave added such feature to prevent some misbehaviour while using reserved words in some conditions but I don't know/remember/understand the scope of these modifications.
IMHO it should be reviewed as it breaks part of the tool.
Andreas tweaked it a bit a little while ago:
http://cvs.pgadmin.org/cgi-bin/viewcvs.cgi/pgadmin3/src/utils/misc.cpp.d iff?r1=1.54&r2=1.55
Seems we need a way to exclude keywords when used in their 'keyword
defining' context (if that makes any sense :-) ).
Yeah, seems I introduced more problems than fixing.
Just introduced qtTypeIdent which will not quote types that are known to the parser. Anybody is invited to review the list in needsQuoting (utils/misc.c) taken from include/parser/parse.h. Diego's list was a starter, but by far not complete.
IMHO quoting column names that are keywords should remain, to indicate to the user that he's doing something he might want to review.
Regards, Andreas
---------------------------(end of broadcast)---------------------------
TIP 9: the planner will ignore your desire to choose an index scan if your
joining column's datatypes do not match
