[pgadmin-hackers] issues w/ 'new' OSX patches

[OpenMacNews]

hi florian,
back to progress on a scratch build.
first, just fyi, your  'newest' patches are (mis?)named:
        pgadmi3-bundle.diff
        pgadmi3-newfiles.tgz
rather than
        pgadmin3-bundle.diff
        pgadmin3-newfiles.tgz
(which kept me guessing for a bit ... amazing how you can stare at similar 
things and NOT see the difference ...)

after successfully re-building today's wxWidgets HEAD
        ../configure \
        --prefix=/usr/local/wxWidgets-cvs \
        --with-mac \
        --disable-shared \
        --disable-debug \
        --enable-unicode \
        --with-regex
DL'ing latest pgadmin3 HEAD, and applying your two patches:
% patch -p0 < pgadmi3-bundle.diff
        patching file Makefile.am
        patching file acinclude.m4
        patching file configure.ac
        patching file pkg/mac/Info.plist
        patching file src/Makefile.am
% gnutar zxvf pgadmi3-newfiles.tgz
        pkg/mac/Info-Debug.plist
        pkg/mac/Makefile.am
        pkg/mac/complete-bundle.sh
        pkg/mac/debug-bundle.sh
        pkg/mac/pgadmin3.icns
a first step of:
% sh bootstrap
now dies at:
	+ '[' -x config ']'
	+ aclocal
	/usr/local/share/aclocal-1.9/libmcrypt.m4:17: warning: underquoted definition 
of AM_PATH_LIBMCRYPT
	  run info '(automake)Extending aclocal'
	  or see http://sources.redhat.com/automake/automake.html#Extending-aclocal
	/usr/local/share/aclocal/libmcrypt.m4:17: warning: underquoted definition of 
AM_PATH_LIBMCRYPT
	+ autoheader
	+ automake --foreign --add-missing --copy
	configure.ac: installing `config/install-sh'
	configure.ac: installing `config/missing'
	src/Makefile.am: installing `config/depcomp'
	configure.ac:8: installing `config/config.guess'
	configure.ac:8: installing `config/config.sub'
	configure.ac:45: required file `pkg/Makefile.in' not found

looking in the 'pgadmi3-bundle.diff' patched configure.ac, i note @ 45:
        42      AC_CONFIG_FILES([Makefile
        43                       src/Makefile
        44               pkg/Makefile
        45               pkg/mac/Makefile])
        46      AC_OUTPUT
yet there's certainly no Makefile* in pkg/ as referenced in line#44, i.e. --
/usr/ports/pgadmin3-cvs % ls pkg
        CVS     fc1  mandrake  pgadmin3.desktop  slackware  win32
        debian  mac  nsis      redhat            src
so, looking in your patch, 'pgadmi3-bundle.diff', there's the obvious 
source:
        139      AC_CONFIG_FILES([Makefile
        140     -                 src/Makefile])
        141     +                 src/Makefile
        142     +        pkg/Makefile
        143     +        pkg/mac/Makefile])
        144      AC_OUTPUT
but i'm wondering what line#142 is referring to.
hmmm .... this worked earlier ...
richard
---------------------------(end of broadcast)---------------------------
TIP 5: Have you checked our extensive FAQ?
              http://www.postgresql.org/docs/faq