Dave Page wrote:
>>But I didn't plan to submit patches for actually opening a saved query
>>with a double-click before 1.4 was branched. I just wanted to make
>>pgAdmin3 announce the extension .sql, and provide an icon for it -
>>something I more or less consider to be part of "behaving like a good
>>osx citizen".
>
> Actually I'd say that's precisely what it doesn't do. By associating the
> icon, you're allowing the user to open that filetype in pgAdmin. Only it
> doesn't. If you leave it un-associated, at least the finder will ask them
> what app to open it in so they can do something useful.

Hm... you're right, I guess.

>>I belive the Info.plist changes I sent are still
>>ok for 1.4 - even if it's a bit strange that pgadmin will startup on
>>double-clicking a file, but won't actually open the query. If you
>>deem that behaviour unacceptably, then I could try to figure out
>>how to prevent it.
>
> Well for no I just rolled back the info.plist changes, and left the makefile > changes and the extra file in place. I guess that should do the job for now. If you rolled back the Info.plist changes, you should revert the Makefile.am, and remove the sql.icns file too - or at least revert the Makefile.am, so that the
sql.icns file doesn't get installed anymore.

Leaving the sql.icns file there does _not_ associate it with .sql files, if thats what you want to accomplish by reverting the Info.plist, and leaving the file there.
The binding of sql.icns <-> .sql extension happens in the Infoo.plist file.

Attached is a new Info.plist file that _prevents_ pgadmin3 from opening when
a user double-clicks a sql-file. It still announces the icon, and still has it's version
set to 1.4. Would you consider using that for 1.4?

Greetings, Florian  Pflug

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple Computer//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd";>
<plist version="1.0">
<dict>
	<key>CFBundleDevelopmentRegion</key>
	<string>English</string>
	<key>CFBundleDocumentTypes</key>
	<array>
		<dict>
			<key>CFBundleTypeExtensions</key>
			<array>
				<string>sql</string>
			</array>
			<key>CFBundleTypeIconFile</key>
			<string>sql.icns</string>
			<key>CFBundleTypeName</key>
			<string>pgAdmin3 SQL Query</string>
			<key>CFBundleTypeRole</key>
			<string>None</string>
			<key>LSItemContentTypes</key>
			<array>
				<string>org.postgresql.pgadmin.sql</string>
			</array>
		</dict>
	</array>
	<key>CFBundleExecutable</key>
	<string>pgAdmin3</string>
	<key>CFBundleGetInfoString</key>
	<string>pgAdmin3 1.4</string>
	<key>CFBundleIconFile</key>
	<string>pgAdmin3.icns</string>
	<key>CFBundleIdentifier</key>
	<string>org.postgresql.pgadmin</string>
	<key>CFBundleInfoDictionaryVersion</key>
	<string>6.0</string>
	<key>CFBundlePackageType</key>
	<string>APPL</string>
	<key>CFBundleShortVersionString</key>
	<string>1.4</string>
	<key>CFBundleSignature</key>
	<string>????</string>
	<key>CFBundleVersion</key>
	<string>1.4</string>
	<key>CSResourcesFileMapped</key>
	<true/>
	<key>UTExportedTypeDeclarations</key>
	<array>
		<dict>
			<key>UTTypeConformsTo</key>
			<array>
				<string>public.utf8-plain-text</string>
			</array>
			<key>UTTypeDescription</key>
			<string>pgAdmin3 SQL Query</string>
			<key>UTTypeIconFile</key>
			<string>sql.icns</string>
			<key>UTTypeIdentifier</key>
			<string>org.postgresql.pgadmin.sql</string>
			<key>UTTypeTagSpecification</key>
			<dict>
				<key>public.filename-extension</key>
				<array>
					<string>sql</string>
				</array>
			</dict>
		</dict>
	</array>
</dict>
</plist>
---------------------------(end of broadcast)---------------------------
TIP 2: Don't 'kill -9' the postmaster

Reply via email to