Dhanaraj M wrote:
Hi Dave

I dont know whether the problem is with pgAdmin or not.
But I have a fix for this.

File name:-  src/frm/frmQuery.cpp

void frmQuery::OnChangeConnection(wxCommandEvent &ev)
{
    unsigned int sel=cbConnection->GetCurrentSelection();

+  if(!IsVisible())
+       return;

    if (sel == cbConnection->GetCount()-1)
    {
        // new Connection
        dlgSelectConnection dlg(this, mainForm);
        int rc=dlg.Go(conn, cbConnection);
----------------------------------------------------------------------------
After closing the query tool, this event is called.
So I am checking whether the window is destroyed already or not.
Is it the right fix?
I am testing in different machines(sparc/x-86) and report you soon.
Please comment on this?

Dhanaraj (and Zdenek). Apologies for not being too responsive over the last few days - as you may have heard, I'm changing job soon so not only do I have the fun of handing all my work over to colleagues here, but I've also been spending time moving some of the PostgreSQL and pgAdmin project infrastructure to a new datacenter before I lose access to this one.

Anyhoo, I agree that this seems a safe fix for the problem your are seeing Dhanaraj and have committed it to the 1.6 branch and trunk - thanks.

What still doesn't make sense is why that function is getting called at all at that point. I can only imagine that wxWidgets is erroneously firing it when the wxCombo is destroyed.

Regards, Dave

---------------------------(end of broadcast)---------------------------
TIP 7: You can help support the PostgreSQL project by donating at

               http://www.postgresql.org/about/donate

Reply via email to