Dave Page a écrit :
> [...]
> On Mon, Oct 27, 2008 at 8:23 AM, Dave Page <[EMAIL PROTECTED]> wrote:
>> On Sun, Oct 19, 2008 at 10:33 PM, Guillaume Lelarge
>> <[EMAIL PROTECTED]> wrote:
>>> Thanks. I still don't like this hack. I hope I'll soon better understand
>>> this issue to replace the ugly code with a good one.
>> You're going to hate this - but I just tested Gevik's work on Windows,
>> and seem to be seeing the SQL and Privilege panes mis-behaving there
>> :-(
>>
>> I wonder if we just need to defer the restoration of the dialogue size
>> to a much later time than it currently is done. Obviously we could
>> just do it at the point that you have your hack at the moment, but it
>> would be nice to do it in the base class. I tried doing this quickly
>> but didn't get too far.
I tried it and it failed.
>> Putting your existing hack towards the end of
>> dlgProperty::Go (but without the WXMAC ifdef) seemed to do the job
>> though - albeit still hackily.
>>
>> Thoughts?
>>
Still a hack but it works. It even works with GTK. The patch attached
removes the WXMAC ifdef.
>> I also found on Windows that the check boxes for different privileges
>> on the privilege panes are touching each other and could use some
>> spacing. Can you look at that please?
>>
I forgot to add a border to the checkboxes. I tried from 4 to 1. 4 was
really big. I still hesitate between 1 et 2. 2 seems better, so that's
the value in the patch. I think you should try both of them and tell us
which one you prefer.
--
Guillaume.
http://www.postgresqlfr.org
http://dalibo.com
Index: pgadmin/ctl/ctlSecurityPanel.cpp
===================================================================
--- pgadmin/ctl/ctlSecurityPanel.cpp (révision 7496)
+++ pgadmin/ctl/ctlSecurityPanel.cpp (copie de travail)
@@ -107,7 +107,7 @@
allPrivilegesGrant = new wxCheckBox(this, CTL_ALLPRIVGRANT, wxT("WITH GRANT OPTION"));
itemSizer5->Add(allPrivilegesGrant, wxEXPAND|wxALIGN_CENTRE_VERTICAL|wxTOP|wxLEFT|wxRIGHT);
allPrivilegesGrant->Disable();
- itemSizer3->Add(itemSizer5, 0, wxALL, 0);
+ itemSizer3->Add(itemSizer5, 0, wxALL, 2);
}
while (privileges.HasMoreTokens())
@@ -122,7 +122,7 @@
itemSizer6->Add(cb, wxEXPAND|wxALIGN_CENTRE_VERTICAL|wxTOP|wxLEFT|wxRIGHT);
cb->Disable();
privCheckboxes[i++] = cb;
- itemSizer3->Add(itemSizer6, 0, wxALL, 0);
+ itemSizer3->Add(itemSizer6, 0, wxALL, 2);
}
}
Index: pgadmin/dlg/dlgFunction.cpp
===================================================================
--- pgadmin/dlg/dlgFunction.cpp (révision 7496)
+++ pgadmin/dlg/dlgFunction.cpp (copie de travail)
@@ -366,12 +366,10 @@
returncode = dlgSecurityProperty::Go(modal);
-#ifdef __WXMAC__
- // This fixes a UI glitch on MacOS X
+ // This fixes a UI glitch on MacOS X and Windows
// Because of the new layout code, the Privileges pane don't size itself properly
SetSize(GetSize().GetWidth()+1, GetSize().GetHeight());
SetSize(GetSize().GetWidth()-1, GetSize().GetHeight());
-#endif
return returncode;
}
Index: pgadmin/dlg/dlgTable.cpp
===================================================================
--- pgadmin/dlg/dlgTable.cpp (révision 7496)
+++ pgadmin/dlg/dlgTable.cpp (copie de travail)
@@ -500,12 +500,10 @@
returncode = dlgSecurityProperty::Go(modal);
-#ifdef __WXMAC__
- // This fixes a UI glitch on MacOS X
+ // This fixes a UI glitch on MacOS X and Windows
// Because of the new layout code, the Privileges pane don't size itself properly
SetSize(GetSize().GetWidth()+1, GetSize().GetHeight());
SetSize(GetSize().GetWidth()-1, GetSize().GetHeight());
-#endif
return returncode;
}
Index: pgadmin/dlg/dlgPackage.cpp
===================================================================
--- pgadmin/dlg/dlgPackage.cpp (révision 7496)
+++ pgadmin/dlg/dlgPackage.cpp (copie de travail)
@@ -86,12 +86,10 @@
returncode = dlgSecurityProperty::Go(modal);
-#ifdef __WXMAC__
- // This fixes a UI glitch on MacOS X
+ // This fixes a UI glitch on MacOS X and Windows
// Because of the new layout code, the Privileges pane don't size itself properly
SetSize(GetSize().GetWidth()+1, GetSize().GetHeight());
SetSize(GetSize().GetWidth()-1, GetSize().GetHeight());
-#endif
return returncode;
}
Index: pgadmin/dlg/dlgTablespace.cpp
===================================================================
--- pgadmin/dlg/dlgTablespace.cpp (révision 7496)
+++ pgadmin/dlg/dlgTablespace.cpp (copie de travail)
@@ -80,12 +80,10 @@
returncode = dlgSecurityProperty::Go(modal);
-#ifdef __WXMAC__
- // This fixes a UI glitch on MacOS X
+ // This fixes a UI glitch on MacOS X and Windows
// Because of the new layout code, the Privileges pane don't size itself properly
SetSize(GetSize().GetWidth()+1, GetSize().GetHeight());
SetSize(GetSize().GetWidth()-1, GetSize().GetHeight());
-#endif
return returncode;
}
Index: pgadmin/dlg/dlgDatabase.cpp
===================================================================
--- pgadmin/dlg/dlgDatabase.cpp (révision 7496)
+++ pgadmin/dlg/dlgDatabase.cpp (copie de travail)
@@ -233,12 +233,10 @@
returncode = dlgSecurityProperty::Go(modal);
-#ifdef __WXMAC__
- // This fixes a UI glitch on MacOS X
+ // This fixes a UI glitch on MacOS X and Windows
// Because of the new layout code, the Privileges pane don't size itself properly
SetSize(GetSize().GetWidth()+1, GetSize().GetHeight());
SetSize(GetSize().GetWidth()-1, GetSize().GetHeight());
-#endif
return returncode;
}
Index: pgadmin/dlg/dlgSequence.cpp
===================================================================
--- pgadmin/dlg/dlgSequence.cpp (révision 7496)
+++ pgadmin/dlg/dlgSequence.cpp (copie de travail)
@@ -127,12 +127,10 @@
returncode = dlgSecurityProperty::Go(modal);
-#ifdef __WXMAC__
- // This fixes a UI glitch on MacOS X
+ // This fixes a UI glitch on MacOS X and Windows
// Because of the new layout code, the Privileges pane don't size itself properly
SetSize(GetSize().GetWidth()+1, GetSize().GetHeight());
SetSize(GetSize().GetWidth()-1, GetSize().GetHeight());
-#endif
return returncode;
}
Index: pgadmin/dlg/dlgView.cpp
===================================================================
--- pgadmin/dlg/dlgView.cpp (révision 7496)
+++ pgadmin/dlg/dlgView.cpp (copie de travail)
@@ -83,12 +83,10 @@
returncode = dlgSecurityProperty::Go(modal);
-#ifdef __WXMAC__
- // This fixes a UI glitch on MacOS X
+ // This fixes a UI glitch on MacOS X and Windows
// Because of the new layout code, the Privileges pane don't size itself properly
SetSize(GetSize().GetWidth()+1, GetSize().GetHeight());
SetSize(GetSize().GetWidth()-1, GetSize().GetHeight());
-#endif
return returncode;
}
Index: pgadmin/dlg/dlgSchema.cpp
===================================================================
--- pgadmin/dlg/dlgSchema.cpp (révision 7496)
+++ pgadmin/dlg/dlgSchema.cpp (copie de travail)
@@ -71,12 +71,10 @@
returncode = dlgSecurityProperty::Go(modal);
-#ifdef __WXMAC__
- // This fixes a UI glitch on MacOS X
+ // This fixes a UI glitch on MacOS X and Windows
// Because of the new layout code, the Privileges pane don't size itself properly
SetSize(GetSize().GetWidth()+1, GetSize().GetHeight());
SetSize(GetSize().GetWidth()-1, GetSize().GetHeight());
-#endif
return returncode;
}
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
