On Sat, Nov 22, 2008 at 10:43 AM, Quan Zongliang <[EMAIL PROTECTED]> wrote: >> That code could use some formatting changes though >> We also try to leave empty lines between distinct blocks of code to >> aid readability. > > Done. > >> - lstColumns should always display the order and nulls values >> - The NULLs radio buttons should not have a shaded box around them. >> - I think the dialogue design would look nicer if the DESC and and >> NULLs options were on the same horizontal alignment, eg: >> >> DESC [] NULLs O FIRST O LAST > > Done.
Thanks - patch applied with minor tweaks to the horizontal layout, and to ensure we always have a direction selected, so it's clear what the user will get. >> - When creating an index with one column, using DESC, I clicked on the >> SQL tab and got an assert: > > I don't get it in Windows XP. > Maybe, when there is default value, my code don't invoke wxListView's > SetItem() and left original value. Is it NULL in Mac? Looks like it was an existing bug that I hadn't spotted before - I've fixed it in SVN. Sorry for the noise. Thanks again for the patch! -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com -- Sent via pgadmin-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
