I will work on this over the weekend, and get a new patch to you Monday evening
> -----Original Message----- > From: Dave Page [mailto:dp...@pgadmin.org] > Sent: Friday, March 06, 2009 7:08 AM > To: Chuck McDevitt > Cc: pgadmin-hackers > Subject: Greenplum patch for pgAdmin > > Hi Chuck, > > I've spent the last few hours working on your patches to pgAdmin. I've > fixed/cleaned up some issues, and had to leave others for you to work > on due to time constraints. Please see the attached patch which > includes all changes and new files, and should apply directly against > a clean source tree from SVN trunk. > > Fixed items > ========= > > * Tablespace creation is disabled for Greenplum servers (do we need to > do the same for any other object types?). > > * gpPartition objects were being created such that their factory > appeared to be tableFactory. This prevented the list of partitions > being displayed and possibly other problems. I've added a new > constructor to pgTable which allows us to pass partitionFactory from > gpPartition::gpPartition. > > * There was an unused additional constructor in gpResourceQueue. > Unfortunately, only that one set the metaType correctly. > > * We no longer offer an option to create a new resource queue. > > Unfixed items > ========== > > * PDF helpfiles are unsupported. You can probably add support for them > fairly easily by hacking up DisplayExternalHelp() (in misc.cpp) to > have it open PDF's in the default browser. > > * The behaviour of gpPartition objects seems bogus to me. There are a > number of issues: > - If I select New Partition from the context menu on the Partitions > node, I get 'Not implemented'. That message box should never be seen > in a release version of pgAdmin - instead, the New Partition menu > option should be removed. That also applies to the 'create an object > of this type' button, which is also enabled when a partition is > selected. > - I'm able to modify partitions by adding or dropping sub objects > such as columns or constraints (albeit, with the occasional > assertion). Shouldn't such options be disabled? > - If I should be able to modify partitions, then the refresh > mechanism is broken, as modified partitions will vanish from the > treeview until the Partitions node is refreshed. > > The following items must also be fixed before release, but needn't > hold up the beta (per previous discussion): > > * isGpApp() should check the output of pg_dump --help for > "--gp-syntax" to determine whether it is a Greenplum utility. > > * gpPartition::GetSQL() should retrun an ALTER TABLE statement. > > Can you let me have an eta for these fixes ASAP please, so I can plan > the beta schedule? The intention is still to release beta 1 early next > week after which no new features will be added until we go into > development mode again. > > Thanks. > > -- > Dave Page > EnterpriseDB UK: http://www.enterprisedb.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
