> -----Original Message----- > From: Dave Page [mailto:dp...@pgadmin.org] > Sent: Saturday, June 06, 2009 2:29 PM > To: Chuck McDevitt > Cc: pgadmin-hackers@postgresql.org > Subject: Re: [pgadmin-hackers] Supporting CSV format log files > > On Fri, Jun 5, 2009 at 8:03 PM, Chuck McDevitt<cmcdev...@greenplum.com> > wrote: > > To extend this to support PostgreSQL 8.4 CSV format log files, I > think we need to do a couple of things: > > > > First, the pg_logdir_ls function from the admin pack would need to be > updated to look for .log or .csv files, not just .log. > > The deadline for submitting changes like that in PostgreSQL 8.4 was > November! > > > Then we would need to recognize that we are reading a file with > extension .csv, and handle it the way I do in the patch for GPDB > (rather than being based on GetIsGreenplum()). > > > > Finally, we'd just need to figure out what each field being logged by > PostgreSQL 8.4 is, and update the code so that it understands that as > well as the GPDB fields. > > That'll have to wait for the next cycle. > > FYI, PostgreSQL and pgAdmin will go to RC1 on Thursday. The intention > is to build the GA release on 25/26 June, for release on the 29th.
Yes, supporting PG CSV logs can certainly wait till next release cycle. But I do need the patch I submitted to be committed, as otherwise the frmStatus display is broken for GPDB, and I'd certainly not want pgAdmin to come out in a form that is broken when using with GPDB. -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
