Looks good to me..
Though not tested..
I will be able to test it tomorrow.

Dave Page wrote:
On Thu, Sep 3, 2009 at 2:08 PM, Sachin
Srivastava<[email protected]> wrote:
Dave,

- bool dlgRepCluster::SlonyMaximumVersion(wxString series, long minor)

should be:

bool dlgRepCluster::SlonyMaximumVersion(const wxString&series, long minor)

Done.
- Just reading the patch, it looks like we never try to load xxid*.sql
any more. That's surely wrong?

Yes. Attached is an updated patch.

Thanks. I've had a quick look, and it looks reasonable to me. Ashesh;
can you review it as well please?

Reply via email to