Le 01/03/2010 21:19, Dave Page a écrit :
> Hi Guillaume,
>
> I just started using a recent snapshot build of pgAdmin, and found
> some display issues in the query tool related to recent changes that
> could use some attention. Please see the attached screenshot:
>
> - The connection drop-down has become rather ugly (the button doesn't
> line up vertically), and requires scrolling even for a tiny list.
>
I still need to work on this one, but right now, I need some sleep.
> - The left-hand margin is the same colour as the text area now. Can we
> make it gray again please?
>
Can you check margincolor.patch? Works OK for me on GTK and Mac OS X.
Didn't bother to check on Windows.
The color used is #dddddd. Probably I should add the ability to
customize it, as we can already customize much of the background and
foreground colors.
> - The buttons to the right of the recent queries combo are not lined up with
> it.
>
Can you check query.patch? Works OK for me on GTK, and is less ugly on
Mac OS X. Is it good enough for you?
--
Guillaume.
http://www.postgresqlfr.org
http://dalibo.com
Index: pgadmin/ctl/ctlSQLBox.cpp
===================================================================
--- pgadmin/ctl/ctlSQLBox.cpp (revision 8191)
+++ pgadmin/ctl/ctlSQLBox.cpp (working copy)
@@ -110,6 +110,8 @@
StyleSetFont(i, fntSQLBox);
}
+ // Margin style
+ StyleSetBackground(wxSTC_STYLE_LINENUMBER, wxColour(0xDD, 0xDD, 0xDD));
// Brace maching styles
StyleSetBackground(34, wxColour(0x99, 0xF9, 0xFF));
StyleSetBackground(35, wxColour(0xFF, 0xCF, 0x27));
Index: pgadmin/frm/frmQuery.cpp
===================================================================
--- pgadmin/frm/frmQuery.cpp (revision 8191)
+++ pgadmin/frm/frmQuery.cpp (working copy)
@@ -423,17 +423,17 @@
// Query combobox
sqlQueries = new wxComboBox(pnlQuery, CTL_SQLQUERYCBOX, wxT(""), wxDefaultPosition, wxDefaultSize, NULL, wxCB_DROPDOWN);
LoadQueries();
- boxHistory->Add(sqlQueries, 1, wxEXPAND | wxALL, 1);
+ boxHistory->Add(sqlQueries, 1, wxEXPAND | wxALL | wxALIGN_CENTER_VERTICAL, 1);
// Delete Current button
btnDeleteCurrent = new wxButton(pnlQuery, CTL_DELETECURRENTBTN, wxT("Delete Current"));
btnDeleteCurrent->Enable(false);
- boxHistory->Add(btnDeleteCurrent, 0, wxALL | wxALIGN_RIGHT, 1);
+ boxHistory->Add(btnDeleteCurrent, 0, wxLEFT | wxRIGHT | wxBOTTOM | wxALIGN_CENTER_VERTICAL, 1);
// Delete All button
btnDeleteAll = new wxButton(pnlQuery, CTL_DELETEALLBTN, wxT("Delete All"));
btnDeleteAll->Enable(sqlQueries->GetCount() > 0);
- boxHistory->Add(btnDeleteAll, 0, wxALL | wxALIGN_RIGHT, 1);
+ boxHistory->Add(btnDeleteAll, 0, wxALL | wxALIGN_CENTER_VERTICAL, 1);
boxQuery->Add(boxHistory, 0, wxEXPAND | wxALL, 1);
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
