Le 26/04/2010 12:01, Dave Page a écrit : > On Mon, Apr 26, 2010 at 10:51 AM, Guillaume Lelarge > <[email protected]> wrote: >> Hi, >> >> While working on the connection combobox for frmQuery, I found some >> rather amusing (or not) bugs in my patch for groups of servers. It seems >> there are quite a few use of the browser that don't like groups. pgAdmin >> doesn't crash, but is not more able to discover servers. Take >> dlgSelectConnection for example. It doesn't crash pgAdmin, but a user >> can't select a new connection because the dialog doesn't find servers >> and disables server and database comboboxes. And I think other >> components will be hit by this. >> >> There is surely simple fixes for them. Problem is: I'm not sure I'll >> have the time to work on those. It could be I will, but I'm simply not sure. >> >> So, I'm a bit hesitant on what to do. I could revert my previous patch, >> and push it in once it's clearly good... but it could be good enought, >> one day after the release of beta 1. I could also try to fix the issues >> (I don't think they are that many), but what should we do if I can't >> have a good enough behaviour when beta 1 will be wrapped up? >> >> I'm actually working on these bugs. So I kind of prefer #2. Any strong >> opinion on this? > > I prefer 2 as well. It's not the end of the world if beta 1 isn't > perfect though, as long it's it's not completely broken. >
It doesn't crash AFAICT, but many parts are hit by this. I tried to find all those parts. Here is what I found: * frmMain::CheckAlive * frmMain::RestoreEnvironment * frmMain::ConnectToServer * frmQuery::GetServerColour * frmGrantWizard::AddObjects * slCluster * dlgRepCluster * dlgSelectConnection::Go They all need a fix. Not a really hard one, it seems pretty obvious for each one of them. But I'm afraid of the ones I didn't find yet. Will work on this, and the combobox. -- Guillaume. http://www.postgresqlfr.org http://dalibo.com -- Sent via pgadmin-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
