Hi Dave,
On Tue, Jun 8, 2010 at 1:20 AM, Dave Page <dp...@pgadmin.org> wrote:
> On Mon, Jun 7, 2010 at 4:31 PM, Ashesh Vashi
> <ashesh.va...@enterprisedb.com> wrote:
> > HI Dave,
> > Please find the patch for the same.
> > If plpgsql does have out parameter, it fails to debug.
> > This patch will apply on both trunk and REL-1_10_PATCHES branch.
>
> Hi Ashesh,
>
> Is that patch right? Surely we should never try to pass a value into
> an OUT parameter.
>
You're right.
We never ask for input from the user for the OUT parameter and the argument
value will always be NULL for these parameters. And hence, this patch worked
for me.
Please find the updated patch.
--
Thanks & Regards,
Ashesh Vashi
EnterpriseDB INDIA: Enterprise Postgres Company<http://www.enterprisedb.com>
Index: debugger/dlgDirectDbg.cpp
===================================================================
--- debugger/dlgDirectDbg.cpp (revision 8413)
+++ debugger/dlgDirectDbg.cpp (working copy)
@@ -691,7 +691,7 @@
declareStatement += wxT(";\n");
query.Append(strParam + wxT(", "));
}
- else
+ else if (arg.getMode() != wxT("o"))
query.Append( arg.quoteValue() + wxT("::") + arg.getType() + wxT(", "));
}
else if(arg.getMode() == wxT("v"))
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
