Hi Dave,
Please find the patch for the same.
--
Thanks & Regards,
Ashesh Vashi
EnterpriseDB INDIA: Enterprise Postgres Company<http://www.enterprisedb.com>
On Tue, Jun 8, 2010 at 2:58 PM, Ashesh Vashi
<[email protected]>wrote:
> Dave,
>
> I am able to reproduce the same on linux too..
> I am looking into it..
>
> Florence,
>
> Thanks for the report.
>
> --
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise Postgres Company<http://www.enterprisedb.com>
>
>
> On Tue, Jun 8, 2010 at 2:47 PM, Cousin Florence <[email protected]>wrote:
>
>>
>> Hi,
>>
>> Pgadmin3 (version 1.12-beta2) crashes with an "The memory could not be
>> read" error on my Windows XP Pro.
>>
>> I can reproduce it this way :
>>
>> 1. connect to an Postgresql 8.4 or 9.0 server
>> 2. go to the schema in the left panel of pgAdmin
>> 3. create a table with no column
>> 4. right-click on the table, add a column
>> 5. fill the fields :
>> name : col1,
>> datatype : character varying (or bigint...)
>> 6. click on the "OK" button.
>>
>>
>>
>> Versions of pgAdmin : 1.12-beta1 and 1.12-beta2 (Jun 3 2010, rev:
>> 8398:8401)
>> (I have tested both)
>> I do not have the problem on an older 1.10 version of pgAdmin.
>> System : Windows XP Pro, in French (so pgAdmin is in French too)
>> Database : Postgresql 8.4 or 9.0
>>
>>
>>
>> Since I do not know if the problem is caused by my system, or pgAdmin
>> itself, I tried to lauch it via the command line. But there is no other
>> error message.
>> I do not see anything in the Event Observer of Windows.
>>
>>
>> Regards,
>>
>> Florence COUSIN
>>
>> --
>> Sent via pgadmin-support mailing list ([email protected])
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-support
>>
>
>
Index: pgadmin/dlg/dlgColumn.cpp
===================================================================
--- pgadmin/dlg/dlgColumn.cpp (revision 8413)
+++ pgadmin/dlg/dlgColumn.cpp (working copy)
@@ -491,6 +491,14 @@
+ wxT("\n ALTER COLUMN ") + qtIdent(name)
+ wxT("\n RESET (") + vars.Item(pos).BeforeFirst('=') + wxT(");\n");
}
+
+ if (cbStorage->GetValue() != column->GetStorage())
+ {
+ sql += wxT("ALTER TABLE ") + table->GetQuotedFullIdentifier()
+ + wxT("\n ALTER COLUMN ") + qtIdent(name)
+ + wxT(" SET STORAGE ") + cbStorage->GetValue()
+ + wxT(";\n");
+ }
}
else
{
@@ -522,14 +530,6 @@
}
}
- if (cbStorage->GetValue() != column->GetStorage())
- {
- sql += wxT("ALTER TABLE ") + table->GetQuotedFullIdentifier()
- + wxT("\n ALTER COLUMN ") + qtIdent(name)
- + wxT(" SET STORAGE ") + cbStorage->GetValue()
- + wxT(";\n");
- }
-
AppendComment(sql, wxT("COLUMN ") + table->GetQuotedFullIdentifier()
+ wxT(".") + qtIdent(name), column);
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
