On Wed, Jan 5, 2011 at 06:05, Ashesh Vashi <[email protected]>wrote:
> > > On Wed, Jan 5, 2011 at 12:37 AM, Magnus Hagander <[email protected]>wrote: > >> On Tue, Jan 4, 2011 at 18:46, Ashesh Vashi <[email protected] >> > wrote: >> >>> Hi Magnus/Dave, >>> >>> This check-in has added one compilation error. >>> The following line introduce an error in file '*pgadmin/db/keywords.c*' >>> *#include <server/parser/gram.h> >>> #include <server/parser/kwlist.h>* >>> >>> Because - these header files does not always find under *`pg_config >>> --includedir`* folder, but can be found under *`pg_config >>> --pkgincludedir`*. >>> >>> Please find the patch to resolve the issue. This applies on both master >>> and REL-1_12_PATCHES branch. >>> >>> >> Looks good in general, but do we actually need to put it on 1.12? The >> keyword build changes were only applied to master, so unless we actually >> *need* it on the back branch, I don't think we should put it there. Is it >> needed for something else as well? >> > You're right. > This patch should only be applied on master. > Thanks, confirmed and applied. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/
