On Wed, Jan 19, 2011 at 00:25, Peter Geoghegan <peter.geoghega...@gmail.com> wrote: > Seems I omitted to copy my system's FlexLexer.h to > ./pgadmin3/pgadmin/include/pgscript. Seemingly the FlexLexer.h that > ships with pgadmin is for Flex 2.5.33 only. I have 2.5.35. > > However, I now get a slightly different set of compiler errors, so I'm > not much better off. > > pgscript/lex.pgs.cc:944:10: error: ‘yy_buffer_stack’ was not declared > in this scope > pgscript/lex.pgs.cc:944:10: error: ‘yy_buffer_stack_top’ was not > declared in this scope > pgscript/lex.pgs.cc:945:27: error: ‘yyensure_buffer_stack’ was not > declared in this scope > pgscript/lex.pgs.cc:1858:8: error: ‘yy_buffer_stack’ was not declared > in this scope > > ...and so on... > > Why do we ship a copy of FlexLexer.h from a specific version of > flex++? Are we really that sensitive to the differences in Flex > versions? Is the easiest thing to get pgadmin to build after changing > the pgscript grammar to use flex 2.5.33, as perhaps suggested in > ./pgadmin3/pgadmin/pgscript/README?
Isn't that part of the "ship the bison/flex output files" thing? We ship lex.pgs.cc parser.tab.cc as well, and that's where the dependency comes from. So we need to ship either both of them or none of them, I think. I don't recall exactly why it was, but the README is pretty specific about the fact that it *is* sensitive. So the version used to generate the .cc files should be the same as the one used for the .h.... -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
