Le 08/04/2011 12:35, Dave Page a écrit : > On Fri, Apr 8, 2011 at 10:50 AM, Guillaume Lelarge > <[email protected]> wrote: >> I think I know why. The OnChangeSize() method is specific to the Mac >> platform. It substracts 550 to the height, but I lower the height a bit, >> so 550 is probably too big now. > > Ahh no - it's because securityPage is NULL for a catalog dialogue - it > just needs the first 2 lines to be guarded with "if (securityPage)". > Not sure what the size is for - it seems to work whatever I set that > too. >
Oh OK. Thanks for the heads-up. This is now fixed (or at least, I hope so :) ). >>> I wonder if it should be 300 wide? The tab labels are all visible now, >>> but the edges aren't. >>> >> >> Done in the patch attached. > > Looks better. > Good to know. >>>>> * big one: 270,250 >>>>> >>>>> But it seems I forgot dlgServer and dlgTable. Just fixed dlgServer. >>>>> Working on dlgTable right now. >>>>> >>>> >>>> Fixed too. >>> >>> :-) > > Hmm, actually the height is still an issue on the Privileges page. See > the attached screenshot. > Fixed. >>>> I fixed also the frmOptions window. >>> >>> Not quite - see the attached screenshot. >>> >> >> Should be fixed in the patch attached. > > Still a little too small - see the other screenshot. > The patch attached makes it a bit bigger. I won't be able to make it bigger though if you want this dialog to work on a 800x600 pixels screen. Wish I had the time to work on the new frmOptions dialog. We wouldn't have this issue... >>> BTW, that one also seems to be missing the status bar. Wanna fix that >>> while you're there? >>> >> >> AFAIR, there is no status bar in the frmOptions window. Do you really >> want to add it to this window? what for? > > It looks a bit crappy for a start - particularly the positioning of > the OK/Cancel buttons. Also for consistency with the other dialogues, > which I think all have a status bar these days. > Status bar added (but unused). -- Guillaume http://www.postgresql.fr http://dalibo.com
>From d81725aa9fde1d50dc559744bf62da7d59764925 Mon Sep 17 00:00:00 2001 From: Guillaume Lelarge <[email protected]> Date: Fri, 8 Apr 2011 15:33:49 +0200 Subject: [PATCH 4/4] Fix other bugs Dave found * fix mac bug with catalogs * fix the Default Privileges page resizing * add more height to frmOptions * add the status bar to frmOptions --- pgadmin/ctl/ctlDefaultSecurityPanel.cpp | 2 +- pgadmin/dlg/dlgProperty.cpp | 7 ++++--- pgadmin/ui/frmOptions.xrc | 12 +++++++++--- 3 files changed, 14 insertions(+), 7 deletions(-) diff --git a/pgadmin/ctl/ctlDefaultSecurityPanel.cpp b/pgadmin/ctl/ctlDefaultSecurityPanel.cpp index bc3edee..56aa3bd 100644 --- a/pgadmin/ctl/ctlDefaultSecurityPanel.cpp +++ b/pgadmin/ctl/ctlDefaultSecurityPanel.cpp @@ -42,7 +42,7 @@ ctlDefaultSecurityPanel::ctlDefaultSecurityPanel(pgConn *conn, wxNotebook *nb, w mainSizer->AddGrowableCol(0); mainSizer->AddGrowableRow(0); - nbNotebook = new wxNotebook(this, -1, wxDefaultPosition, wxSize(220, 470), 0, _("Default ACLs")); + nbNotebook = new wxNotebook(this, -1, wxDefaultPosition, wxDefaultSize, 0, _("Default ACLs")); m_defPrivOnTablesPanel = new ctlDefaultPrivilegesPanel(this, nbNotebook, g_defPrivTables, imgList); m_defPrivOnSeqsPanel = new ctlDefaultPrivilegesPanel(this, nbNotebook, g_defPrivSequences, imgList); diff --git a/pgadmin/dlg/dlgProperty.cpp b/pgadmin/dlg/dlgProperty.cpp index 027fcae..8828e14 100644 --- a/pgadmin/dlg/dlgProperty.cpp +++ b/pgadmin/dlg/dlgProperty.cpp @@ -1659,11 +1659,12 @@ dlgSecurityProperty::~dlgSecurityProperty() #ifdef __WXMAC__ void dlgSecurityProperty::OnChangeSize(wxSizeEvent &ev) { - securityPage->lbPrivileges->SetSize(wxDefaultCoord, wxDefaultCoord, - ev.GetSize().GetWidth(), ev.GetSize().GetHeight() - 550); + if (securityPage) + securityPage->lbPrivileges->SetSize(wxDefaultCoord, wxDefaultCoord, + ev.GetSize().GetWidth(), ev.GetSize().GetHeight() - 550); if (GetAutoLayout()) { - Layout(); + Layout(); } } #endif diff --git a/pgadmin/ui/frmOptions.xrc b/pgadmin/ui/frmOptions.xrc index 31c5399..78e3015 100644 --- a/pgadmin/ui/frmOptions.xrc +++ b/pgadmin/ui/frmOptions.xrc @@ -2,7 +2,7 @@ <resource> <object class="wxDialog" name="frmOptions"> <title>Options</title> - <size>350,290d</size> + <size>350,310d</size> <style>wxDEFAULT_DIALOG_STYLE|wxCAPTION|wxSYSTEM_MENU|wxRESIZE_BORDER</style> <object class="wxFlexGridSizer"> <cols>1</cols> @@ -1033,8 +1033,14 @@ <border>3</border> </object> </object> - <flag>wxEXPAND|wxALL</flag> - <border>0</border> + <flag>wxEXPAND|wxTOP|wxLEFT|wxRIGHT</flag> + </object> + <object class="sizeritem"> + <object class="wxStatusBar" name="unkStatusBar"> + <style>wxST_SIZEGRIP</style> + </object> + <flag>wxEXPAND|wxALIGN_CENTRE</flag> + <border>3</border> </object> </object> </object> -- 1.7.1
-- Sent via pgadmin-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
