On Tue, 2011-07-12 at 10:55 +0100, Thom Brown wrote: > On 12 July 2011 10:53, Dave Page <dp...@pgadmin.org> wrote: > > On Sat, Jul 9, 2011 at 9:02 PM, Thom Brown <t...@linux.com> wrote: > >> Hi (yes, me... again), > >> > >> Tiny patch attached to prevent adding attributes with a duplicate name > >> to a type. It seems previous versions prevented this, but must have > >> been allowed in a commit since the last release. > > > > For consistency with the other checks on the dialogue, this should > > cause the "Add" button to be disabled, not make it silently fail. That > > should almost certainly be done in dlgType::CheckChange(). > > Yes, you're right. >
Does this patch need to be applied after the "overhaul of type attributes" one? -- Guillaume http://blog.guillaume.lelarge.info http://www.dalibo.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
