On Tue, 2011-11-01 at 08:47 -0200, Vinicius Santos wrote:
> Hello,
> 
> I implemented a function for the two buttons "Asc" and "Desc", so that
> the maintenance
> is easier.
> 
> Take a look and tell me what you think.
> 

Well, I don't like the UI. It takes too much space for only one
information. I would better like a combobox, with the two choices.

Moreover, it simply doesn't work on Linux. I've got an assertion failure
on OnPaint for the list. I actually don't understand why, but it works
without your patch, so I guess your patch is buggy here.

Something that would be interesting to add is a collation widget. Since
9.1, you can add a collation information to a sort. That would be worth
adding.

Anyway, please, fix the UI, try to fix the Linux bug if you can
(otherwise, I can do it), and add the collation stuff. Will be an
interesting patch to commit.

Thanks.


-- 
Guillaume
  http://blog.guillaume.lelarge.info
  http://www.dalibo.com


-- 
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Reply via email to