On Mon, Nov 14, 2011 at 8:19 AM, Guillaume Lelarge <[email protected]> wrote: > On Sun, 2011-11-13 at 22:10 +0000, Dave Page wrote: >> I just noticed this thread. Does the patch update the tab completion >> code (tab-complete.inc, iirc) to the latest from PG 9.1? I don't think >> we remembered to do that this release, so it probably should. >> > > This patch shouldn't. It adds new features on the autocompletion, > features that have nothing to do with the autocompletion code from 9.1.
Even if the patch doesn't directly update the file, it should be updated first. FYI, I just took a look at the patch and it does touch tab-complete.inc - it certainly should *not* do that, as tab-complete.inc is generated with tabcomplete.pl from the upstream tab-complete.c. Any changes made to it are likely to be lost the next time it's updated. If that file must be changed, then it should be done by tab-complete.pl, though frankly it would be better to push the changes into psql first. > But I agree we forgot to update this file, and that it should be done > soon. I'm not sure if we should do that also for the 1.14 branch? any > opinions on this one? If it updates cleanly, I don't mind. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
