On Tue, Jan 10, 2012 at 3:44 PM, Dave Page <[email protected]> wrote:
> On Tue, Jan 10, 2012 at 10:09 AM, Akshay Joshi > <[email protected]> wrote: > > > > On Tue, Jan 10, 2012 at 3:09 PM, Dave Page <[email protected]> wrote: > >> > >> On Tue, Jan 10, 2012 at 9:36 AM, Guillaume Lelarge > >> <[email protected]> wrote: > >> > On Tue, 2012-01-10 at 14:31 +0530, Akshay Joshi wrote: > >> >> Hi Dave > >> >> > >> >> Modified the logic. Attached is the patch file, please review it. > >> >> > >> > > >> > This is still wrong. bIsChangeComment isn't always true when the user > >> > creates a replication cluster. It's only true if there is a comment. > >> > >> Seems a little long-winded too - can't you just replace the current > >> IsEmpty() test with something like "if (txtComment->GetValue() != > >> cluster->GetComment())"? > > > > > > No, I can't because when we create new Slony I-cluster > > "cluster->GetComment()" will not work as cluster object is NULL at that > > moment. > > If ((!cluster && !txtComment.IsEmpty()) || (cluster && > cluster->GetComment() != txtComment->GetValue()) ? > It works. Attached the modified patch. > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- *Akshay Joshi Senior Software Engineer EnterpriseDB Corporation The Enterprise PostgreSQL Company Phone: +91 20-3058-9522 Mobile: +91 976-788-8246*
FB_20417_v2.patch
Description: Binary data
-- Sent via pgadmin-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
