On 4 March 2012 16:03, Dave Page <dp...@pgadmin.org> wrote:
> On Sun, Mar 4, 2012 at 3:48 PM, Thom Brown <t...@linux.com> wrote:
>> Hi all,
>>
>> I haven't tried building PgAdmin in quite a while now, so have started
>> from scratch again.  I seem to be getting the following problem:
>>
>> make  install-data-hook
>> make[3]: Entering directory `/home/thom/Development/pgadmin3'
>> chmod 0666 
>> //home/thom/Development/pgadmin/share/pgadmin3/docs/en_US/pgadmin3.hhp.cached
>> chmod: cannot access
>> `//home/thom/Development/pgadmin/share/pgadmin3/docs/en_US/pgadmin3.hhp.cached':
>> No such file or directory
>> make[3]: *** [install-data-hook] Error 1
>> make[3]: Leaving directory `/home/thom/Development/pgadmin3'
>> make[2]: *** [install-data-am] Error 2
>> make[2]: Leaving directory `/home/thom/Development/pgadmin3'
>> make[1]: *** [install-am] Error 2
>> make[1]: Leaving directory `/home/thom/Development/pgadmin3'
>> make: *** [install-recursive] Error 1
>>
>> The pgadmin3.hhp.cached file used to exist in that directory until
>> mid-2011 when it was removed.  Obviously it can't be critical as
>> otherwise it wouldn't still be gone, but it keeps looking for it.
>>
>> What am I doing wrong?
>
> Actually, it is kinda important in an installation, but was removed
> because it's not created automatically by the new help system. Feel up
> to tweaking the makefile so it touches the file then chmod's it? We
> only really need to install an empty file so we can set the
> permissions on it (which actually probably shouldn't be 0666) - the
> help browser will store it's cache data in there when run. Better yet,
> we should probably figure out how to make it put it in /tmp, so we
> don't need to mess around with permissions at all...

Well it sounds ridiculously trivial, so maybe I've misunderstood.
(patch attached)

And the build has stopped whining now.  Thanks Dave.

-- 
Thom
diff --git a/Makefile.am b/Makefile.am
index 2309c7f..4e79b97 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -64,6 +64,7 @@ endif
 
 # We need to ensure the help cache is world writeable
 install-data-hook:
+	touch $(help_cache)
 	chmod 0666 $(help_cache)
 
 # Perform astyle cleanup per rules:
-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Reply via email to