On Fri, 2012-04-20 at 10:47 +0200, Guillaume Lelarge wrote:
> On Fri, 2012-04-20 at 09:21 +0100, Dave Page wrote:
> > Hi
> >
> > On Thu, Apr 19, 2012 at 9:59 PM, Heikki Linnakangas
> > <[email protected]> wrote:
> > > And now that I've updated my local repository, here's a third version that
> > > actually applies. (just my working copy didn't fix the issue)
> >
> > With this change, the dialogue no longer meets our design standard.
> >
> > Please see
> > http://wiki.postgresql.org/wiki/PgAdmin_Internals#Property_page_dialogue_layout,
> > which should be the standard for all new/updated dialogues, except in
> > exceptional circumstances (with justification).
> >
>
> I worked a bit on Heikki's patch yesterday evening and this morning. It
> seems pgAdmin hangs when I want to debug functions with parameters. If
> my function doesn't have any parameter, it works well.
>
> IOW, it hangs when we call Show on the dlgDirectDeg dialog.
>
> I don't understand why though. The XRC file seems good to me.
>
I took a look at the thread Heikki mentionned in his first mail. One of
the issue he had was fixed by setting the size of the COL_NAME column.
We don't do that if we have to show the dialog. So I added the same
statement, and it works now. Kinda puzzling, but it works. And we still
meet our design standard. See attached patch.
Heikki, is this patch working for you?
--
Guillaume
http://blog.guillaume.lelarge.info
http://www.dalibo.com
diff --git a/pgadmin/debugger/dlgDirectDbg.cpp b/pgadmin/debugger/dlgDirectDbg.cpp
index 85224fd..0398fac 100644
--- a/pgadmin/debugger/dlgDirectDbg.cpp
+++ b/pgadmin/debugger/dlgDirectDbg.cpp
@@ -294,7 +294,10 @@ void dlgDirectDbg::populateParamGrid( )
activateDebugger();
}
else
+ {
+ grdParams->SetColSize(COL_NAME, 200);
this->ShowModal();
+ }
}
////////////////////////////////////////////////////////////////////////////////
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
