On Tue, 2012-09-11 at 12:20 -0300, Vinicius Santos wrote:
> 
> 
>         Got some time to work on this. SetLabel is useful for widgets,
>         not for
>         windows. Change your call to the SetLabel() method with a call
>         to
>         SetTitle(). Works great for me on Linux. Don't know on
>         Windows, maybe
>         you could check?
> 
> OK. I changed it.
>  
>         
>         About your patch, it seems good so far. My only issue is that,
>         when I
>         click on the root node, or on a servers group node, it still
>         displays
>         the old connection string. It shouldn't. It should get back to
>         "pgAdmin
>         III".
> 
> Here, I would like the opinion of you.
> 
> When the user clicks on the "Database" node, the pgAdmin is connected
> to the database "postgres".
> So, would not it be interesting to show this information?
> 

Well, as far as I know, pgadmin could be connected to many databases. It
should only display the connection it used to get the informations on
the selected object.

>  
>         
>         Another thing that bugs me. To show the full name of an
>         object, you use
>         this code:
>         
>         GetSchema()->GetName() + wxT(".") + GetName()
>         
>         instead of the simpler:
>         
>         GetFullIdentifier()
> 
> GetFullIdentifier() doesn't show the same information.
> 
> 
> We can't change it, because it is used in several other places.

Are you sure? 


-- 
Guillaume
http://blog.guillaume.lelarge.info
http://www.dalibo.com



-- 
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Reply via email to