That would be very good. I would be pleased to test...
Op 25-okt.-2013 om 09:10 heeft Neel Patel <neel.pa...@enterprisedb.com> het volgende geschreven: > Hi Dave, > > Sven wants to test this slony 2.2.0 patch and they are using slony > replication but he doesn't have development environment to apply this patch. > So can we give him executable for testing according to his environment or any > other way to test this patch ? > > Thanks, > Neel Patel > > > > On Thu, Oct 24, 2013 at 10:43 AM, Neel Patel <neel.pa...@enterprisedb.com> > wrote: >> Hi, >> >> Once we complete the testing and code review, we will commit the code and it >> will be available in next pgAdmin release but don't know about the next >> release of pgAdmin. >> >> Thanks, >> Neel Patel >> >> >> >> On Tue, Oct 22, 2013 at 11:42 PM, Sven Meirsman <sven.meirs...@gmail.com> >> wrote: >>> Neel, >>> >>> I do not have experience with these kind of builds. I do have Visual Studio >>> 2010 but the detailed steps on how to build from source do not work. >>> Will this patch be in a new pgAdmin release soon? >>> >>> Sven >>> >>> >>> 2013/10/22 Neel Patel <neel.pa...@enterprisedb.com> >>>> Hi Sven, >>>> >>>> Download pgadmin source code, apply this new patch and compile the source >>>> code. >>>> >>>> To test this you have to build the development environment required by >>>> pgadmin. >>>> >>>> Thanks, >>>> Neel Patel >>>> >>>> >>>> On Tue, Oct 22, 2013 at 5:37 PM, Sven Meirsman <sven.meirs...@gmail.com> >>>> wrote: >>>>> Neel, >>>>> >>>>> Thanks for this good news. I would be happy to test this out, as I am >>>>> waiting for a fix. However, how should I go about and install this patch? >>>>> I had a look at the contents of the file included and it looks like a >>>>> diff between source code. >>>>> >>>>> I do not have the means to compile this... >>>>> >>>>> Sven >>>>> >>>>> >>>>> 2013/10/22 Neel Patel <neel.pa...@enterprisedb.com> >>>>>> Hi Dave, >>>>>> >>>>>> We have fixed the below two issues to support in Slony version 2.2.0 >>>>>> with PG 9.3 in pgAdmin. >>>>>> >>>>>> Issue 1:- >>>>>> >>>>>> Bug to reproduce:- >>>>>> >>>>>> - Install PG 9.3 and slony 2.2.0 >>>>>> - Right click on database and click on option "New slony-I cluster..." >>>>>> - In the dialog we are able to see the error in status bar saying >>>>>> "Slony-I creation scripts not available; only joining possible" >>>>>> >>>>>> Solution :- >>>>>> >>>>>> As per the above conversation in new version of slony 2.2.0 installation >>>>>> name of the sql files got changed so it is not able to find the current >>>>>> slony version. >>>>>> >>>>>> >>>>>> Issue 2:- >>>>>> >>>>>> "storenode" API contains three argument in slony version 1.1 and 1.2 but >>>>>> in slony version 2.0 onwards it contains only two arguments so that >>>>>> issue also fixed. >>>>>> >>>>>> >>>>>> As per our knowledge we have tested this patch in slony 2.2.0 with PG >>>>>> 9.3. >>>>>> >>>>>> Can anyone please test this patch and let us know if any bugs. >>>>>> >>>>>> >>>>>> Thanks, >>>>>> Neel Patel >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> On Fri, Oct 11, 2013 at 5:17 PM, Neel Patel >>>>>> <neel.pa...@enterprisedb.com> wrote: >>>>>>> Hi Sven, >>>>>>> >>>>>>> No idea regarding the next release. >>>>>>> >>>>>>> Thanks, >>>>>>> Neel Patel >>>>>>> >>>>>>> >>>>>>> On Fri, Oct 11, 2013 at 11:46 AM, Sven Meirsman >>>>>>> <sven.meirs...@gmail.com> wrote: >>>>>>>> Hi, >>>>>>>> >>>>>>>> Thanks for the feedback. I'm looking forward to this update. Any idea >>>>>>>> on when it will be released? >>>>>>>> >>>>>>>> regards, >>>>>>>> Sven >>>>>>>> >>>>>>>> >>>>>>>> 2013/10/11 Neel Patel <neel.pa...@enterprisedb.com> >>>>>>>>> Hi Sven, >>>>>>>>> >>>>>>>>> Sorry for the late replay, we have checked and it is a bug in pgAdmin >>>>>>>>> because the name of the sql files got changed in new slony version ( >>>>>>>>> v2.2.0 ) which is used by the pgAdmin. >>>>>>>>> >>>>>>>>> Issue :- >>>>>>>>> >>>>>>>>> When we install the slony ( version less than 2.2.0 ) then it will >>>>>>>>> install below sql files in C:\Program Files\PostgreSQL\9.3\share >>>>>>>>> folder. >>>>>>>>> >>>>>>>>> slony1_base.sql >>>>>>>>> slony1_base.v83.sql >>>>>>>>> slony1_base.v84.sql >>>>>>>>> slony1_funcs.sql >>>>>>>>> slony1_funcs.v83.sql >>>>>>>>> slony1_funcs.v84.sql >>>>>>>>> >>>>>>>>> Now in New version of slony 2.2.0 onwards the name of the above sql >>>>>>>>> files got changed as below. >>>>>>>>> >>>>>>>>> slony1_base.2.2.0.sql >>>>>>>>> slony1_base.v83.2.2.0.sql >>>>>>>>> slony1_base.v84.2.2.0.sql >>>>>>>>> slony1_funcs.2.2.0.sql >>>>>>>>> slony1_funcs.v83.2.2.0.sql >>>>>>>>> slony1_funcs.v84.2.2.0.sql >>>>>>>>> >>>>>>>>> As we are using above sql files names in pgAdmin to create the new >>>>>>>>> slony clusters so we need to change in pgAdmin also. >>>>>>>>> >>>>>>>>> We are working on this issue and submit the patch once its done. >>>>>>>>> >>>>>>>>> Thanks, >>>>>>>>> Neel Patel >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> On Mon, Sep 30, 2013 at 2:05 AM, Guillaume Lelarge >>>>>>>>> <guilla...@lelarge.info> wrote: >>>>>>>>>> On Sun, 2013-09-29 at 22:29 +0200, Sven Meirsman wrote: >>>>>>>>>> > Sorry, My mistake. >>>>>>>>>> > >>>>>>>>>> > 'Binary Paths' is the section you choose at the left of the >>>>>>>>>> > screen. It >>>>>>>>>> > contains several paths, one 'PG Bin Path' is directing to my >>>>>>>>>> > postgres BIN >>>>>>>>>> > folder like you suggest. It is the Slony-I path that contains the >>>>>>>>>> > path to >>>>>>>>>> > the postgres SHARE folder where the slony scripts reside. >>>>>>>>>> > >>>>>>>>>> >>>>>>>>>> Oh OK, you're right. >>>>>>>>>> >>>>>>>>>> On the Slony issue, I see that Dave commited a patch from Neel Patel >>>>>>>>>> last thursday. This patch commit log is: "Ensure DDLScript will work >>>>>>>>>> with Slony 2.2+ which has a new SQL level API.". So I guess this is >>>>>>>>>> what >>>>>>>>>> you're looking for. This will be in the next minor release (1.18.1), >>>>>>>>>> which should be available on thursday 10th october. >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> Guillaume >>>>>>>>>> http://blog.guillaume.lelarge.info >>>>>>>>>> http://www.dalibo.com >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> Sent via pgadmin-support mailing list >>>>>>>>>> (pgadmin-supp...@postgresql.org) >>>>>>>>>> To make changes to your subscription: >>>>>>>>>> http://www.postgresql.org/mailpref/pgadmin-support >