On 03/03/2014 02:44 PM, Dave Page wrote:
On Mon, Mar 3, 2014 at 1:05 PM, Andreas 'ads' Scherbaum
<[email protected]> wrote:
On 03/03/2014 11:32 AM, Dave Page wrote:
On Mon, Mar 3, 2014 at 10:20 AM, Andreas 'ads' Scherbaum
<[email protected]> wrote:
Yes, I know how to fix this. My question is: why is "configure" not
checking
for this library, when it is required to build pgAdmin3?
Noone wrote the code I guess. Patches welcome :-)
Just checking the code: why is it even requiring "crypto" when compiling
without --with-openssl?
That's actually the likely reason why we don't do that test. It seems
to be required because we're linking with libpq which is linked with
OpenSSL, apps linking to it (on some platforms) also need to link with
libcypto. It may also be that an element of bitrot has crept into that
configure option - I very much doubt anyone has tested without SSL
support in a long time.
Given what you said, attached is a patch which requires "openssl/ssl.h"
to be available. If not, configure bails out with an error message.
Regards,
--
Andreas 'ads' Scherbaum
German PostgreSQL User Group
European PostgreSQL User Group - Board of Directors
Volunteer Regional Contact, Germany - PostgreSQL Project
diff --git a/configure.ac.in b/configure.ac.in
index 0ad0d5e..a510de0 100644
--- a/configure.ac.in
+++ b/configure.ac.in
@@ -92,6 +92,9 @@ if test "$ac_cv_libssl" != "yes" && test "$use_libgcrypt" != "no"; then
LIBSREQUIRED=libgcrypt
fi
+# libpq requires SSL anyway, check if the devel package is installed
+AC_CHECK_HEADER(openssl/ssl.h, , [AC_MSG_ERROR([Couldn't find openssl/ssl.h...install the OpenSSL devel package] )])
+
AC_SUBST(LIBSREQUIRED)
if test "$ac_cv_libssl" != "yes" && test "$ac_cv_libgcrypt" != "yes"; then
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
